From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8P9H-0007gy-Nh for qemu-devel@nongnu.org; Thu, 02 Jun 2016 05:42:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8P9D-0004wX-IG for qemu-devel@nongnu.org; Thu, 02 Jun 2016 05:42:42 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:46512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8P9D-0004vf-70 for qemu-devel@nongnu.org; Thu, 02 Jun 2016 05:42:39 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Jun 2016 10:42:37 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 144442190069 for ; Thu, 2 Jun 2016 10:42:07 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u529gXsW7799128 for ; Thu, 2 Jun 2016 09:42:33 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u529gXB1020608 for ; Thu, 2 Jun 2016 03:42:33 -0600 Date: Thu, 2 Jun 2016 11:42:29 +0200 From: Greg Kurz Message-ID: <20160602114229.41c06a80@bahia.huguette.org> In-Reply-To: References: <146485751812.31047.11608773464731615044.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] 9p: get rid of readdir_r() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Aneesh Kumar K.V" , QEMU Developers , Michael Fritscher On Thu, 2 Jun 2016 10:33:06 +0100 Peter Maydell wrote: > On 2 June 2016 at 09:51, Greg Kurz wrote: > > The readdir_r() function has a broken design and should not be used anymore. > > It is expected to be obsoleted in a future version of POSIX.1: > > > > http://austingroupbugs.net/view.php?id=696#c2857 > > > > Glibc has already announced that 2.24 (scheduled for August 2016) will > > deprecates readdir_r() and encourages people to use readdir() with > > external synchronization instead. > > > Since POSIX.1 will require readdir() to be thread-safe when employed on > > different directory streams, and glibc already does that, the choice > > was made to have per-directory locking. > > AIUI the argument is that all sensible implementations of readdir() > already provide the thread-safety guarantees POSIX is going to > specify, but have you tested this on one of the BSDs or OSX? > (and/or checked their current readdir implementation...) > No I haven't because "VirtFS is supported only on Linux" at the moment. But thanks for raising the flag: it reminds me that there's ongoing work to support VirtFS on win32 hosts and I should also Cc Michael Fritscher. Thanks ! -- Greg > thanks > -- PMM >