From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57135)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=954140592=anthony.perard@citrix.com>)
	id 1b8UKR-0001Sz-H4
	for qemu-devel@nongnu.org; Thu, 02 Jun 2016 11:14:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=954140592=anthony.perard@citrix.com>)
	id 1b8UKN-0005qY-9U
	for qemu-devel@nongnu.org; Thu, 02 Jun 2016 11:14:34 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:18346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=954140592=anthony.perard@citrix.com>)
	id 1b8UKN-0005pd-1Q
	for qemu-devel@nongnu.org; Thu, 02 Jun 2016 11:14:31 -0400
Date: Thu, 2 Jun 2016 16:14:18 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <20160602151418.GJ1184@perard.uk.xensource.com>
References: <1464863806-1984-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1464863806-1984-2-git-send-email-xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1464863806-1984-2-git-send-email-xiecl.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: qemu devel <qemu-devel@nongnu.org>, Stefano Stabellini <sstabellini@kernel.org>, Juan Quintela <quintela@redhat.com>, Amit Shah <amit.shah@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Wen
	Congyang <wency@cn.fujitsu.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

On Thu, Jun 02, 2016 at 06:36:46PM +0800, Changlong Xie wrote:
> +void qmp_xen_load_devices_state(const char *filename, Error **errp)
> +{
> +    QEMUFile *f;
> +    QIOChannelFile *ioc;
> +    int ret;
> +
> +    /* Guest must be paused before loading the device state; the RAM state
> +     * will already have been loaded by xc
> +     */
> +    if (runstate_is_running()) {
> +        error_setg(errp, "Cannot update device state while vm is running");
> +        return;
> +    }
> +    vm_stop(RUN_STATE_RESTORE_VM);
> +
> +    ioc = qio_channel_file_new_path(filename, O_WRONLY | O_CREAT, 0660, errp);

This does not look right, it looks like it's going to open the file
to write to it. You probably want O_RDONLY, also I don't think the
O_CREAT flag is needed. (and without O_WRONLY, mode can be 0 instead of
0660.)

> +    if (!ioc) {
> +        return;
> +    }
> +    f = qemu_fopen_channel_output(QIO_CHANNEL(ioc));

I'm not sure, but I guess here you want qemu_fopen_channel_input here.

Thanks,

-- 
Anthony PERARD