From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8f48-0003lW-3q for qemu-devel@nongnu.org; Thu, 02 Jun 2016 22:42:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8f46-0007JE-8x for qemu-devel@nongnu.org; Thu, 02 Jun 2016 22:42:27 -0400 Date: Fri, 3 Jun 2016 10:42:17 +0800 From: Fam Zheng Message-ID: <20160603024217.GG29298@ad.usersys.redhat.com> References: <1457412306-18940-1-git-send-email-famz@redhat.com> <1457412306-18940-10-git-send-email-famz@redhat.com> <56E2E188.6060005@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E2E188.6060005@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 09/15] block: Support meta dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, kwolf@redhat.com On Fri, 03/11 16:17, Max Reitz wrote: > On 08.03.2016 05:45, Fam Zheng wrote: > > The added group of operations enables tracking of the changed bits in > > the dirty bitmap. > > > > Signed-off-by: Fam Zheng > > --- > > block/dirty-bitmap.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ > > include/block/dirty-bitmap.h | 9 ++++++++ > > 2 files changed, 61 insertions(+) > > Should we truncate the meta bitmaps in bdrv_dirty_bitmap_truncate()? > Yes, adding that. Thanks! Fam