From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8hMK-0006dV-0K for qemu-devel@nongnu.org; Fri, 03 Jun 2016 01:09:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8hMI-0007dh-Js for qemu-devel@nongnu.org; Fri, 03 Jun 2016 01:09:23 -0400 Date: Fri, 3 Jun 2016 15:06:28 +1000 From: David Gibson Message-ID: <20160603050627.GH1087@voom.fritz.box> References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com> <1463024905-28401-7-git-send-email-bharata@linux.vnet.ibm.com> <20160602033858.GM15455@voom.fritz.box> <20160602181209.GA31052@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bg2esWel0ueIH/G/" Content-Disposition: inline In-Reply-To: <20160602181209.GA31052@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Bharata B Rao , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de, imammedo@redhat.com, armbru@redhat.com, thuth@redhat.com, aik@ozlabs.ru, agraf@suse.de, pbonzini@redhat.com, pkrempa@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com, mjrosato@linux.vnet.ibm.com, borntraeger@de.ibm.com --Bg2esWel0ueIH/G/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 02, 2016 at 03:12:09PM -0300, Eduardo Habkost wrote: > On Thu, Jun 02, 2016 at 01:38:58PM +1000, David Gibson wrote: > > On Thu, May 12, 2016 at 09:18:16AM +0530, Bharata B Rao wrote: > > > Add an abstract CPU core type that could be used by machines that want > > > to define and hotplug CPUs in core granularity. > > >=20 > > > Signed-off-by: Bharata B Rao > > > Signed-off-by: Igor Mammedov > > > [Integer core property] > > > Reviewed-by: David Gibson > >=20 > > Igor, Eduardo, > >=20 > > Do you think we're comfortable enough with this abstract core concept > > to merge it now? If so which tree should it go through? >=20 > TBH, I haven't reviewed the concept carefully. I hoped that > people that spent more time thinking about long-term plans > (especially Andreas) would help move the discussion forward, but > Andreas is moving away from QOM CPU. >=20 > I need to review the previous discussions more carefully, but the > concept looks simple enough to me, and I don't think we should > hold spapr work because we want a Grand Plan for generic CPU > abstractions to be finished first. If David, Igor, and the people > working on spapr are happy with it, I trust their judgement. >=20 > I just wish the interface was better documented, especially the > meaning of the "core" and "threads" properties. I would prefer to > have "core-id" as the property name instead of "core" (most of > the error messages related to it (in patch 08/15) say "core id"). Ok, I've renamed the properties to 'core-id' and 'nr-threads' as I merged, which I think is clearer. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Bg2esWel0ueIH/G/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXURBTAAoJEGw4ysog2bOSfUIQAIGjqd1NB5oiIYAlKmjlvpv8 d1m5S7gjrN/FH1nA+BVf0OKCsU03V0hvF/yLokEhJJqwelNjtjFcqmQDivdaecGi Kpv5B89r0Kq4a7it/dmTih2opIrxTVZBN97z2XsB9m2CJeyx7BUoTjEirryEaHOd HWyJQPmVqs59SRpKeEy5vMtNuhUtWlgj5Hf3bQ4unpiFBZ7hlf4tbO8KxvoSdl7E VOaeTKDcgpcVDgul7QCLDnzKxKMILhTxhnfXvvlTg/Px6i4IZjfnwKbJ/F4TTzGP +7XnjAdhD7Y5bVu7kehtbZ2LIo7D5UBFwKe8xOxNY8xhUSwUNmiZJmcB5J6dJujC OUP8m3FI50f586vkoCfk3Y9dZL+n7R/hefzPc78LSZHdogK6zmug5Biof5aasSjP T0m/F8zqnuIvDHNKPb7NvkVSsWWFO6Q4qvhJmre0Mqs5MiHP2dd5nTnuTq6EPR33 5/fhByZ8yv8BNxyjWtwgYolbwgzYid2YtQkSWKXDNQWO0TJA1pdHnFmK6jBcHr8m uyRBg7mzoCLyBi6uLlMEQw9ZCeZVQMaFXf1Z4VVz8w+AVpHPEbR1ITs9VYIWq9ud nCCcW/Lnt/gBeprF6lGb5/H6NOZZQVwJsVYuyYNFSkw1Y/f6bNgFOiIOCF4Hxy4Y XXFoXmtXsJ/BzlskZe8j =7mMw -----END PGP SIGNATURE----- --Bg2esWel0ueIH/G/--