From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8ixa-0006NM-5z for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:51:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8ixY-0003fD-LM for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:51:58 -0400 Date: Fri, 3 Jun 2016 16:27:48 +1000 From: David Gibson Message-ID: <20160603062748.GP1087@voom.fritz.box> References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com> <1463024905-28401-13-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vzUQzca511KWT6Hk" Content-Disposition: inline In-Reply-To: <1463024905-28401-13-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 12/15] spapr: CPU hot unplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de, imammedo@redhat.com, armbru@redhat.com, thuth@redhat.com, aik@ozlabs.ru, agraf@suse.de, pbonzini@redhat.com, ehabkost@redhat.com, pkrempa@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com, mjrosato@linux.vnet.ibm.com, borntraeger@de.ibm.com --vzUQzca511KWT6Hk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 12, 2016 at 09:18:22AM +0530, Bharata B Rao wrote: > Remove the CPU core device by removing the underlying CPU thread devices. > Hot removal of CPU for sPAPR guests is achieved by sending the hot unplug > notification to the guest. Release the vCPU object after CPU hot unplug so > that vCPU fd can be parked and reused. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Couple of suggestions for minor improvements below, though. > --- > hw/ppc/spapr.c | 16 ++++++++ > hw/ppc/spapr_cpu_core.c | 81 +++++++++++++++++++++++++++++++++++= ++++++ > include/hw/ppc/spapr.h | 1 + > include/hw/ppc/spapr_cpu_core.h | 11 ++++++ > 4 files changed, 109 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 8c3100d..a8cd74d 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2342,11 +2342,27 @@ static void spapr_machine_device_plug(HotplugHand= ler *hotplug_dev, > } > } > =20 > +void spapr_cpu_destroy(PowerPCCPU *cpu) I think this would make more sense in spapr_cpu_core.c (where it could be static). > +{ > + sPAPRMachineState *spapr =3D SPAPR_MACHINE(qdev_get_machine()); > + > + xics_cpu_destroy(spapr->icp, cpu); > + qemu_unregister_reset(spapr_cpu_reset, cpu); > +} > + > static void spapr_machine_device_unplug(HotplugHandler *hotplug_dev, > DeviceState *dev, Error **errp) > { > + sPAPRMachineClass *smc =3D SPAPR_MACHINE_GET_CLASS(qdev_get_machine(= )); > + > if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { > error_setg(errp, "Memory hot unplug not supported by sPAPR"); > + } else if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) { > + if (!smc->dr_cpu_enabled) { > + error_setg(errp, "CPU hot unplug not supported on this machi= ne"); > + return; > + } > + spapr_core_unplug(hotplug_dev, dev, errp); > } > } > =20 > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index ed36beb..0b62456 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -28,6 +28,87 @@ char *spapr_get_cpu_core_type(const char *model) > return g_strdup(core_type); > } > =20 > +static void spapr_cpu_core_cleanup(struct sPAPRCPUUnplugList *unplug_lis= t) > +{ > + sPAPRCPUUnplug *unplug, *next; > + Object *cpu; > + > + QLIST_FOREACH_SAFE(unplug, unplug_list, node, next) { > + cpu =3D unplug->cpu; > + object_unparent(cpu); > + QLIST_REMOVE(unplug, node); > + g_free(unplug); > + } > +} > + > +static void spapr_add_cpu_to_unplug_list(Object *cpu, > + struct sPAPRCPUUnplugList *unpl= ug_list) > +{ > + sPAPRCPUUnplug *unplug =3D g_malloc(sizeof(*unplug)); > + > + unplug->cpu =3D cpu; > + QLIST_INSERT_HEAD(unplug_list, unplug, node); > +} > + > +static int spapr_cpu_release(Object *obj, void *opaque) > +{ > + DeviceState *dev =3D DEVICE(obj); > + CPUState *cs =3D CPU(dev); > + PowerPCCPU *cpu =3D POWERPC_CPU(cs); > + struct sPAPRCPUUnplugList *unplug_list =3D opaque; > + > + spapr_cpu_destroy(cpu); > + cpu_remove_sync(cs); > + > + /* > + * We are still walking the core object's children list, and > + * hence can't cleanup this CPU thread object just yet. Put > + * it on a list for later removal. > + */ > + spapr_add_cpu_to_unplug_list(obj, unplug_list); > + return 0; > +} > + > +static void spapr_core_release(DeviceState *dev, void *opaque) > +{ > + struct sPAPRCPUUnplugList unplug_list; > + sPAPRMachineState *spapr =3D SPAPR_MACHINE(qdev_get_machine()); > + sPAPRCPUCore *core =3D SPAPR_CPU_CORE(OBJECT(dev)); > + CPUCore *cc =3D CPU_CORE(dev); > + int smt =3D kvmppc_smt_threads(); > + > + QLIST_INIT(&unplug_list); > + object_child_foreach(OBJECT(dev), spapr_cpu_release, &unplug_list); > + spapr_cpu_core_cleanup(&unplug_list); > + spapr->cores[cc->core / smt] =3D NULL; Could you avoid the awkwardness with the two phase release by stepping through the cc->threads array instead of using object_child_foreach()? > + > + g_free(core->threads); > + object_unparent(OBJECT(dev)); > +} > + > +void spapr_core_unplug(HotplugHandler *hotplug_dev, DeviceState *dev, > + Error **errp) > +{ > + sPAPRCPUCore *core =3D SPAPR_CPU_CORE(OBJECT(dev)); > + PowerPCCPU *cpu =3D &core->threads[0]; > + int id =3D ppc_get_vcpu_dt_id(cpu); > + sPAPRDRConnector *drc =3D > + spapr_dr_connector_by_id(SPAPR_DR_CONNECTOR_TYPE_CPU, id); > + sPAPRDRConnectorClass *drck; > + Error *local_err =3D NULL; > + > + g_assert(drc); > + > + drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(drc); > + drck->detach(drc, dev, spapr_core_release, NULL, &local_err); > + if (local_err) { > + error_propagate(errp, local_err); > + return; > + } > + > + spapr_hotplug_req_remove_by_index(drc); > +} > + > void spapr_core_plug(HotplugHandler *hotplug_dev, DeviceState *dev, > Error **errp) > { > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index ca4ae3e..a443693 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -585,6 +585,7 @@ void spapr_hotplug_req_remove_by_count(sPAPRDRConnect= orType drc_type, > void spapr_cpu_init(sPAPRMachineState *spapr, PowerPCCPU *cpu, Error **e= rrp); > void *spapr_populate_hotplug_cpu_dt(CPUState *cs, int *fdt_offset, > sPAPRMachineState *spapr); > +void spapr_cpu_destroy(PowerPCCPU *cpu); > =20 > /* rtas-configure-connector state */ > struct sPAPRConfigureConnectorState { > diff --git a/include/hw/ppc/spapr_cpu_core.h b/include/hw/ppc/spapr_cpu_c= ore.h > index 4cd837e..3d8d6ac 100644 > --- a/include/hw/ppc/spapr_cpu_core.h > +++ b/include/hw/ppc/spapr_cpu_core.h > @@ -30,4 +30,15 @@ void spapr_core_pre_plug(HotplugHandler *hotplug_dev, = DeviceState *dev, > char *spapr_get_cpu_core_type(const char *model); > void spapr_core_plug(HotplugHandler *hotplug_dev, DeviceState *dev, > Error **errp); > +void spapr_core_unplug(HotplugHandler *hotplug_dev, DeviceState *dev, > + Error **errp); > + > +/* List to store unplugged CPU objects for cleanup during unplug */ > +typedef struct sPAPRCPUUnplug { > + Object *cpu; > + QLIST_ENTRY(sPAPRCPUUnplug) node; > +} sPAPRCPUUnplug; > + > +QLIST_HEAD(sPAPRCPUUnplugList, sPAPRCPUUnplug); > + > #endif --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --vzUQzca511KWT6Hk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXUSNkAAoJEGw4ysog2bOSFsAQANAXC/bktwwsHtHXK8Ga+ece T+x6bQzgVgqyOo/NM0QYsC2yzsMJiOS9LxZRB2dw1Vygb6Ar3JYnARMaL2jnOZmV +rzIGo0mIdSh9wjD2kYqqWZW4dUnp/vfBaNorR5u6Ol7pN9uwpMw0Bh+wxEJiYpv lmchtGCxppHyLOqdhvtYWgMv4LWbGWGVygMHQOMqkXXrRilB3v7rWz0pAd470nxq rkU5AGC543m5kRlwh7oMJj47KxUoRdwfcKk9bp0/K+SsEExf/VZ/VdryZTGwNCLw qWy1/joMkfDnoTlJ2PvfwXTvHgEYVj7OxD96KlmOu9L4I1VJtEOJtZ1HsJZYJyaE AF0/FuRXCL1tJyj9BX4yZYovnxXHx1aRTnVhOZGsmZqMwCwQWRQkjBgRrenShHCi 8lNwtVGdtLXy7G/Mir4upyQNVYQtvqNz6WoBLkkc+FiaOwAyZRZhbXfgVIeW2WOt PNFiIxbTNjKKHGLGeX6CVyPXFzdb9P9bZPG3XMb0AmT6bBpKKQh8jHXuGIbSbHLq HLt0IOHWBl0VPEiM9R014s/ms06S6DBqAugpNRSqPQquNGgl/W1ffINfRFqHsJp+ qOWc9i8TEltgOxQdjSbVYMZP44lQkX4sCFFhzDUPwN0IZMqdW+SFRA51Fqu71oBH z9+wShNkMmszQ7+ev7Lz =dcRD -----END PGP SIGNATURE----- --vzUQzca511KWT6Hk--