From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b8ihB-0005ay-4E
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:35:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b8ih7-000069-Ut
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:35:01 -0400
Date: Fri, 3 Jun 2016 14:34:50 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160603063450.GK29298@ad.usersys.redhat.com>
References: <1463470536-8981-1-git-send-email-famz@redhat.com>
	<1463470536-8981-20-git-send-email-famz@redhat.com>
	<7821f2b3-0a95-8adc-295d-eac2690b2614@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7821f2b3-0a95-8adc-295d-eac2690b2614@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 19/27] qemu-iotests: 140: Disable image
 lock for qemu-io access
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>, qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com

On Wed, 05/25 15:16, Max Reitz wrote:
> On 17.05.2016 09:35, Fam Zheng wrote:
> > The VM is still on, the image locking check would complain.
> 
> No, it wouldn't. We are opening an NBD URL that is provided by the VM.
> 
> Even if it would, we are only reading data, so an -r would probably be
> better than an -L.

You are right, I am dropping this patch.

Fam

> 
> Max
> 
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  tests/qemu-iotests/140 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140
> > index 49f9df4..3be656a 100755
> > --- a/tests/qemu-iotests/140
> > +++ b/tests/qemu-iotests/140
> > @@ -70,7 +70,7 @@ _send_qemu_cmd $QEMU_HANDLE \
> >         'arguments': { 'device': 'drv' }}" \
> >      'return'
> >  
> > -$QEMU_IO_PROG -f raw -c 'read -P 42 0 64k' \
> > +$QEMU_IO_PROG -f raw -L -c 'read -P 42 0 64k' \
> >      "nbd+unix:///drv?socket=$TEST_DIR/nbd" 2>&1 \
> >      | _filter_qemu_io | _filter_nbd
> >  
> > 
> 
>