From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1b8mxO-0003F7-Nr
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 07:08:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1b8mxJ-0000Qf-JA
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 07:08:01 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57314)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1b8mxH-0000P2-AK
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 07:07:57 -0400
Date: Fri, 3 Jun 2016 07:07:45 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20160603110745.GC5251@flamenco>
References: <1464138802-23503-1-git-send-email-cota@braap.org>
	<1464138802-23503-14-git-send-email-cota@braap.org>
	<574B56D6.7030707@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <574B56D6.7030707@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 13/15] qht: add test-qht-par to invoke
 qht-bench from 'check' target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@listserver.greensocs.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On Sun, May 29, 2016 at 23:53:42 +0300, Sergey Fedorov wrote:
> On 25/05/16 04:13, Emilio G. Cota wrote:
> (snip)
> > +
> > +#define TEST_QHT_STRING "tests/qht-bench 1>/dev/null 2>&1 -R -S0.1 -D10000 -N1"
> > +
> > +static void test_qht(int n_threads, int update_rate, int duration)
> > +{
> > +    char *str;
> > +    int rc;
> > +
> > +    str = g_strdup_printf(TEST_QHT_STRING "-n %d -u %d -d %d",
> 
> There needs to be an extra space either at the beginning of the literal
> string, or at the end of the string defined by TEST_QHT_STRING, so that
> we don't get "... -N1-n ...".

Good catch! Changed now.

Thanks,

		Emilio