From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] qemu-img bench: Add --flush-interval
Date: Fri, 3 Jun 2016 17:16:21 +0200 [thread overview]
Message-ID: <20160603151621.GC5712@noname.redhat.com> (raw)
In-Reply-To: <57519BBE.5040204@openvz.org>
Am 03.06.2016 um 17:01 hat Denis V. Lunev geschrieben:
> On 06/03/2016 03:30 PM, Kevin Wolf wrote:
> >This options allows to flush the image periodically during write tests.
> >
> >Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> This pattern could be a bit different - you wait requests to finish
> and after that start flush. In this case there is no gain with my
> patch ;)
>
> You should treat flush as ordinary write request i.e. place
> request immediately without waiting for writes to finish.
> May be this could be specified as an operation mode.
Hm, okay, I can try that.
What OS is running on your guest? Because I seem to remember that Linux
drains the queue before sending a flush command. This is why I
implemented it this way here. Maybe it changed in Linux, though.
Kevin
next prev parent reply other threads:[~2016-06-03 15:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 12:30 [Qemu-devel] [PATCH 0/5] block: Introduce qemu-img bench Kevin Wolf
2016-06-03 12:30 ` [Qemu-devel] [PATCH 1/5] " Kevin Wolf
2016-06-06 9:59 ` Denis V. Lunev
2016-06-03 12:30 ` [Qemu-devel] [PATCH 2/5] qemu-img bench: Sequential writes Kevin Wolf
2016-06-03 14:55 ` Denis V. Lunev
2016-06-03 12:30 ` [Qemu-devel] [PATCH 3/5] qemu-img bench: Make start offset configurable Kevin Wolf
2016-06-06 10:02 ` Denis V. Lunev
2016-06-03 12:30 ` [Qemu-devel] [PATCH 4/5] qemu-img bench: Implement -S (step size) Kevin Wolf
2016-06-06 10:03 ` Denis V. Lunev
2016-06-03 12:30 ` [Qemu-devel] [PATCH 5/5] qemu-img bench: Add --flush-interval Kevin Wolf
2016-06-03 15:01 ` Denis V. Lunev
2016-06-03 15:16 ` Kevin Wolf [this message]
2016-06-06 12:33 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603151621.GC5712@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).