[Qemu-devel] [PATCH] iotests: 095: Clean up QEMU before showing image info

[Qemu-devel] [PATCH] iotests: 095: Clean up QEMU before showing image info

[Fam Zheng]

Somehow in my locking series, I missed this case where concurrent access
to an image is performed, perhaps we can remove this case independently.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/095 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/095 b/tests/qemu-iotests/095
index dad04b9..030adb2 100755
--- a/tests/qemu-iotests/095
+++ b/tests/qemu-iotests/095
@@ -74,6 +74,8 @@ _send_qemu_cmd $h "{ 'execute': 'block-commit',
                                  'arguments': { 'device': 'test',
                                  'top': '"${TEST_IMG}.snp1"' } }" "BLOCK_JOB_COMPLETED"
 
+_cleanup_qemu
+
 echo
 echo "=== Base image info after commit and resize ==="
 TEST_IMG="${TEST_IMG}.base" _img_info | _filter_img_info
-- 
2.8.2

Re: [Qemu-devel] [PATCH] iotests: 095: Clean up QEMU before showing image info

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On 03.06.2016 11:07, Fam Zheng wrote:
> Somehow in my locking series, I missed this case where concurrent access
> to an image is performed, perhaps we can remove this case independently.

The patch itself is good, but this commit message will not make much
sense in the git log. I'd be fine with removing it completely because
the title itself should be sufficient. (Which is something I can do in
case you agree.)

Max

> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/095 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/095 b/tests/qemu-iotests/095
> index dad04b9..030adb2 100755
> --- a/tests/qemu-iotests/095
> +++ b/tests/qemu-iotests/095
> @@ -74,6 +74,8 @@ _send_qemu_cmd $h "{ 'execute': 'block-commit',
>                                   'arguments': { 'device': 'test',
>                                   'top': '"${TEST_IMG}.snp1"' } }" "BLOCK_JOB_COMPLETED"
>  
> +_cleanup_qemu
> +
>  echo
>  echo "=== Base image info after commit and resize ==="
>  TEST_IMG="${TEST_IMG}.base" _img_info | _filter_img_info
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH] iotests: 095: Clean up QEMU before showing image info

[Fam Zheng]

On Fri, 06/03 16:52, Max Reitz wrote:
> On 03.06.2016 11:07, Fam Zheng wrote:
> > Somehow in my locking series, I missed this case where concurrent access
> > to an image is performed, perhaps we can remove this case independently.
> 
> The patch itself is good, but this commit message will not make much
> sense in the git log. I'd be fine with removing it completely because
> the title itself should be sufficient. (Which is something I can do in
> case you agree.)

Yes, agreed completely. Thanks!

Fam

Re: [Qemu-devel] [PATCH] iotests: 095: Clean up QEMU before showing image info

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On 03.06.2016 11:07, Fam Zheng wrote:
> Somehow in my locking series, I missed this case where concurrent access
> to an image is performed, perhaps we can remove this case independently.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/095 | 2 ++
>  1 file changed, 2 insertions(+)

Thanks, Fam, I've removed the commit message and applied the patch to my
block branch:

https://github.com/XanClic/qemu/commits/block


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH] iotests: 095: Clean up QEMU before showing image info

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

On 03.06.2016 11:07, Fam Zheng wrote:
> Somehow in my locking series, I missed this case where concurrent access
> to an image is performed, perhaps we can remove this case independently.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/095 | 2 ++
>  1 file changed, 2 insertions(+)

Thanks, Fam, I've removed the commit message and applied the patch to my
block branch:

https://github.com/XanClic/qemu/commits/block

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]