From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9jeS-0006xl-KU for qemu-devel@nongnu.org; Sun, 05 Jun 2016 21:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9jeM-0000mB-OB for qemu-devel@nongnu.org; Sun, 05 Jun 2016 21:48:24 -0400 Date: Mon, 6 Jun 2016 11:47:53 +1000 From: David Gibson Message-ID: <20160606014753.GH9226@voom.fritz.box> References: <1464955880-10176-1-git-send-email-clg@kaod.org> <57518BA1.1030400@ilande.co.uk> <5754645E.8080504@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8/pVXlBMPtxfSuJG" Content-Disposition: inline In-Reply-To: <5754645E.8080504@kaod.org> Subject: Re: [Qemu-devel] [PATCH 0/3] ppc: complete the new HV mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Mark Cave-Ayland , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --8/pVXlBMPtxfSuJG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 05, 2016 at 07:41:50PM +0200, C=E9dric Le Goater wrote: > Hello Mark, >=20 > On 06/03/2016 03:52 PM, Mark Cave-Ayland wrote: > > On 03/06/16 13:11, C=E9dric Le Goater wrote: > >=20 > >> This is follow up to complete the serie "ppc: preparing pnv landing > >> (round 2)" plus a little fix on instruction privileges. > >> > >> Tested on a POWER8 pserie guest and on mac99. > >> > >> Benjamin Herrenschmidt (2): > >> ppc: Fix hreg_store_msr() so that non-HV mode cannot alter MSR:HV > >> ppc: Better figure out if processor has HV mode > >> > >> C=E9dric Le Goater (1): > >> ppc: fix hrfid, tlbia and slbia privilege > >> > >> target-ppc/cpu.h | 4 ++++ > >> target-ppc/excp_helper.c | 8 ++++++-- > >> target-ppc/helper_regs.h | 4 ++-- > >> target-ppc/translate.c | 10 ++++++---- > >> target-ppc/translate_init.c | 19 +++++++++++++++---- > >> 5 files changed, 33 insertions(+), 12 deletions(-) > >=20 > > Hi C=E9dric, > >=20 > > I can confirm that this patchset fixes starting up OpenBIOS for both > > g3beige/mac99 in my tests here. With the escc fix also applied, the only > > outstanding issue is the removal of the tlb_flush() statements which > > causes Darwin, MacOS X and HelenOS 0.60 to panic on boot > >=20 > > My only request is if it would be possible to move patch 2 "ppc: Better > > figure out if processor has HV mode" to the front of this patchset which > > will make the remaining patches bisectable for the Mac machines. With t= hat: > >=20 > > Tested-by: Mark Cave-Ayland > >=20 > > Does anyone know if Ben has any ideas as to why the MMU tlb_flush > > changes patch is causing such problems? >=20 >=20 > Here is a fix I think. Could you give it a try ?=20 So, I had applied this to ppc-for-2.7, but I've now removed it again. BenH correctly pointed out that it basically just removes any benefit of his original tlb_flush() patch, in a slightly more subtle way that the last "fix". You just set the need_flush flag whenever IR or DR are changed, whereas the whole point of BenH's patch is that the translation on and off modes are now different MM contexts, which should be flagged in qemu's TLB and so not require a full flush. We need to work out what the real problem is here. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8/pVXlBMPtxfSuJG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXVNZJAAoJEGw4ysog2bOS8MwQANVH6tS2/QrVpimhfhalJ8p+ VHExD4/GEWBVZrwxEIiNuaaocuIbwePvQBQDg4+E3+JmRDdLTD+7/KnMKCcv8ESi wNHLd/tXnSCLAicB1kinPNZ6Gf/VLfjVXNng3g7fobw+a/qzoUpy7nZc4sJMQ1CN o1nhpOFU28a8tBIukseWPDnS3t7WLjqpOIJmSkj9P5t49RbU918SA33/dHhGffrP 56b9gjN8kJ/fITNsahgNxeJgsYB4+0wh+m9B4/Xo0D4h/15lV2WiR7UPFhATzySW BGHzhXH4VxHiPdc+8hbUA/M6623/o6WtMBabdhvUzNLEGfCslkVCKK/L645g1jIr Qy/UpMY+sE1ynlbsdeN/w5SOCCBNgFAy/C3d9Fuo3H+nWsQ+HfRkfZ3vFhduS5y/ TmWHbFDTzs9PkrZ1eVMe6isAUCumkGd+7jlAFice0B9yot6+NF6SiPVGr2dwOQ89 U6cAmn1eNNhEDDrU7Qf2/sFhu8yJ/Q0ELtdARzolYGX7rcmpcegpdzTBZ2RNSZfq 1psArSqb97YjiJyVS7VsA+AFlSOwTffP4CK6bDqUhrSExaFeKFR9nFX3fee19HOd s2gJJI3Mv7XhKoYeBEavyKIaIm2YTEFVm7lIDZlfIwtuUUZNXLjk7r3PIe1Sd067 QUNLa2RBeHAlZFMfL17D =4HZr -----END PGP SIGNATURE----- --8/pVXlBMPtxfSuJG--