From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9qC9-0000xz-6M for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:47:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9qC5-0002tK-Vn for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:47:37 -0400 Date: Mon, 6 Jun 2016 10:47:28 +0200 From: Jakub Horak Message-ID: <20160606084728.GB24720@ibawizard> References: <20160603154549.GA31406@ibawizard> <20160606013441.GF9226@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160606013441.GF9226@voom.fritz.box> Subject: Re: [Qemu-devel] Bug in ppc/BookE wait instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Hello, David Gibson (david@gibson.dropbear.id.au) wrote: > On Fri, Jun 03, 2016 at 05:45:49PM +0200, Jakub Horak wrote: > > Hello, > > I think there's a bug in "wait" instruction code generator for PowerPC > > architecture. It doesn't make sense to store a non-initialized register. > > > > Best regards, > > Jakub Horak > > The fix looks correct, but I need a Signed-off-by line in order to > apply it. Here you go: Fixed bug in code generator. Signed-off-by: Jakub Horak diff --git a/target-ppc/translate.c b/target-ppc/translate.c index f5ceae5..6af567b 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -3439,7 +3439,7 @@ static void gen_sync(DisasContext *ctx) /* wait */ static void gen_wait(DisasContext *ctx) { - TCGv_i32 t0 = tcg_temp_new_i32(); + TCGv_i32 t0 = tcg_const_i32(1); tcg_gen_st_i32(t0, cpu_env, -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted)); tcg_temp_free_i32(t0); > > In future, please send such patches to myself and Alex Graf > (target-ppc maintainers) the qemu-ppc list as well as qemu-devel. I > wouldn't have spotted this if Marc Cave-Ayland hadn't copied it to me. Sorry, I'll be more thoughtful next time. Best regards, Jakub > > > > > > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > > index f5ceae5..6af567b 100644 > > --- a/target-ppc/translate.c > > +++ b/target-ppc/translate.c > > @@ -3439,7 +3439,7 @@ static void gen_sync(DisasContext *ctx) > > /* wait */ > > static void gen_wait(DisasContext *ctx) > > { > > - TCGv_i32 t0 = tcg_temp_new_i32(); > > + TCGv_i32 t0 = tcg_const_i32(1); > > tcg_gen_st_i32(t0, cpu_env, > > -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted)); > > tcg_temp_free_i32(t0); > > > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson