From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA06X-0000YS-K5 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 15:22:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA06T-0003t2-Je for qemu-devel@nongnu.org; Mon, 06 Jun 2016 15:22:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA06T-0003ss-Bw for qemu-devel@nongnu.org; Mon, 06 Jun 2016 15:22:25 -0400 Date: Mon, 6 Jun 2016 20:22:20 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160606192219.GB2258@work-vm> References: <1465234520-11160-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/11] Misc changes for 2016-06-06 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , QEMU Developers * Peter Maydell (peter.maydell@linaro.org) wrote: > On 6 June 2016 at 18:35, Paolo Bonzini wrote: > > The following changes since commit 76462405809d29bab65a3699686998ba12= 4ab942: > > > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm= -20160606-1' into staging (2016-06-06 17:02:42 +0100) > > > > are available in the git repository at: > > > > git://github.com/bonzini/qemu.git tags/for-upstream > > > > for you to fetch changes up to ada3d3ba63016bcd33c42f84bcc982a249768e= 36: > > > > avx2 configure: Use primitives in test (2016-06-06 19:18:34 +0200) > > > > ---------------------------------------------------------------- > > * max-ram-below-4g improvement (Gerd) > > * escc fix (xiaoqiang) > > * ESP fix (Prasad) > > * scsi-disk tweaks/fix (me) > > * PKGVERSION improvement (Fam) > > * -vnc man improvement (Robert) > > * AVX2 configure fixes (Dave) >=20 > Hi. I'm afraid this fails to build for me (x86-64 Linux, gcc). >=20 > I think this is the "trying to use the #pragma target("avx2") doesn't > work under ccache" problem again. (configure tests run not under ccache= , > but the build proper does.) See > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05298.html > from last time we tried this... >=20 > Possibly it's just that you deleted the "requires gcc 4.9" check with > the comment that says "this doesn't work with older gcc", so now > we're again trying to do this on the older gcc where it doesn't work ;-= ) >=20 > Compiler errors below. Sigh I see; so the configure test is run with a different set of compiler options than the main compiles? How is any configure test supposed to check that it's got a sane configuration? In that case, I suggest the fix is to leave the change to the configure script, but for the moment leave the #if QEMU_GNUC_PREREG(4, 9) Dave >=20 >=20 > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98can_use_buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:275:29: error: > =E2=80=98__m256i=E2=80=99 undeclared (first use in this function) > * sizeof(AVX2_VECTYPE)) =3D=3D 0 > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:275:29: note: each > undeclared identifier is reported only once for each function it > appears in > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:281:5: error: > unknown type name =E2=80=98__m256i=E2=80=99 > const AVX2_VECTYPE *p =3D buf; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:282:5: error: > unknown type name =E2=80=98__m256i=E2=80=99 > const AVX2_VECTYPE zero =3D (AVX2_VECTYPE){0}; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:282:27: error: > =E2=80=98__m256i=E2=80=99 undeclared (first use in this function) > const AVX2_VECTYPE zero =3D (AVX2_VECTYPE){0}; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:282:35: error: > expected =E2=80=98,=E2=80=99 or =E2=80=98;=E2=80=99 before =E2=80=98{=E2= =80=99 token > const AVX2_VECTYPE zero =3D (AVX2_VECTYPE){0}; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:292:9: error: > implicit declaration of function =E2=80=98_mm256_movemask_epi8=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > if (!AVX2_ALL_EQ(p[i], zero)) { > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:292:9: error: > nested extern declaration of =E2=80=98_mm256_movemask_epi8=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:292:9: error: > implicit declaration of function =E2=80=98_mm256_cmpeq_epi8=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:292:9: error: > nested extern declaration of =E2=80=98_mm256_cmpeq_epi8=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:300:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp0=E2=80=99 > AVX2_VECTYPE tmp0 =3D AVX2_VEC_OR(p[i + 0], p[i + 1]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:301:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp1=E2=80=99 > AVX2_VECTYPE tmp1 =3D AVX2_VEC_OR(p[i + 2], p[i + 3]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:302:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp2=E2=80=99 > AVX2_VECTYPE tmp2 =3D AVX2_VEC_OR(p[i + 4], p[i + 5]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:303:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp3=E2=80=99 > AVX2_VECTYPE tmp3 =3D AVX2_VEC_OR(p[i + 6], p[i + 7]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:304:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp01=E2=80=99 > AVX2_VECTYPE tmp01 =3D AVX2_VEC_OR(tmp0, tmp1); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:305:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp23=E2=80=99 > AVX2_VECTYPE tmp23 =3D AVX2_VEC_OR(tmp2, tmp3); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:306:9: error: > implicit declaration of function =E2=80=98_mm256_or_si256=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > if (!AVX2_ALL_EQ(AVX2_VEC_OR(tmp01, tmp23), zero)) { > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:306:9: error: > nested extern declaration of =E2=80=98_mm256_or_si256=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:306:71: error: > =E2=80=98tmp01=E2=80=99 undeclared (first use in this function) > if (!AVX2_ALL_EQ(AVX2_VEC_OR(tmp01, tmp23), zero)) { > = ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:306:78: error: > =E2=80=98tmp23=E2=80=99 undeclared (first use in this function) > if (!AVX2_ALL_EQ(AVX2_VEC_OR(tmp01, tmp23), zero)) { > = ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98can_use_buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:277:1: error: > control reaches end of non-void function [-Werror=3Dreturn-type] > } > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:312:1: error: > control reaches end of non-void function [-Werror=3Dreturn-type] > } > ^ > cc1: all warnings being treated as errors >=20 >=20 > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK