From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA7dK-0001uj-OC for qemu-devel@nongnu.org; Mon, 06 Jun 2016 23:24:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA7dF-00043a-LC for qemu-devel@nongnu.org; Mon, 06 Jun 2016 23:24:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA7dF-00043W-F8 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 23:24:45 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E3D2C00FAAD for ; Tue, 7 Jun 2016 03:24:45 +0000 (UTC) Date: Tue, 7 Jun 2016 11:24:40 +0800 From: Fam Zheng Message-ID: <20160607032440.GC2273@ad.usersys.redhat.com> References: <1465228434-20143-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465228434-20143-1-git-send-email-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH] docker: Don't use eval trick on Makefile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Paolo Bonzini On Mon, 06/06 12:53, Eduardo Habkost wrote: > The eval trick for defining DOCKER_SRC_COPY doesn't do anything > useful, as DOCKER_SRC_COPY is immediately expanded just after it > is defined, and CUR_TIME is already defined using ":=". Simply > define it using ":=" so it is evaluated only once. > > The eval trick was also triggering an weird error on Travis builds: > qemu/tests/docker/Makefile.include:34: *** unterminated variable reference. Stop. > > The issue is not easily reproducible (maybe it's a bug in some > versions of Make), but it is avoided if removing the eval trick. > > Signed-off-by: Eduardo Habkost > --- > tests/docker/Makefile.include | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > index 2fd2ca3..134dc6f 100644 > --- a/tests/docker/Makefile.include > +++ b/tests/docker/Makefile.include > @@ -28,8 +28,7 @@ make-archive-maybe = $(if $(wildcard $1/*), \ > " ARCHIVE $(notdir $2)")) > > CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.$$$$) > -# Makes the definition constant after the first expansion > -DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY) > +DOCKER_SRC_COPY := docker-src.$(CUR_TIME) > > $(DOCKER_SRC_COPY): > @mkdir $@ > -- > 2.5.5 > Applied, thanks. Fam