qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Colin Lord <clord@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, qemu-block@nongnu.org,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] blockdev: clean up error handling in do_open_tray
Date: Tue, 7 Jun 2016 12:16:36 +0200	[thread overview]
Message-ID: <20160607101636.GC4684@noname.str.redhat.com> (raw)
In-Reply-To: <1465236922-11063-1-git-send-email-clord@redhat.com>

Am 06.06.2016 um 20:15 hat Colin Lord geschrieben:
> Returns negative error codes and accompanying error messages in cases where
> the device has no tray or the tray is locked and isn't forced open. This
> extra information should result in better flexibility in functions that
> call do_open_tray.
> 
> Signed-off-by: Colin Lord <clord@redhat.com>
> Suggested by: Markus Armbruster <armbru@redhat.com>

Thanks, updated the queued patch with this.

As a minor remark, I think that having Suggested-by first is more common
because it matches the chronological order: First someone suggested the
change, then someone did the patch, and then someone merges it (that's
my S-o-b that I add while applying the patch). For the same reason, I
generally add Reviewed-by tags after the author's, but before my own
maintainer S-o-b.

Kevin

      reply	other threads:[~2016-06-07 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 18:15 [Qemu-devel] [PATCH v3] blockdev: clean up error handling in do_open_tray Colin Lord
2016-06-07 10:16 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607101636.GC4684@noname.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=clord@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).