From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAE3u-00041d-Hy for qemu-devel@nongnu.org; Tue, 07 Jun 2016 06:16:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAE3t-00066s-Lu for qemu-devel@nongnu.org; Tue, 07 Jun 2016 06:16:42 -0400 Date: Tue, 7 Jun 2016 12:16:36 +0200 From: Kevin Wolf Message-ID: <20160607101636.GC4684@noname.str.redhat.com> References: <1465236922-11063-1-git-send-email-clord@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465236922-11063-1-git-send-email-clord@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] blockdev: clean up error handling in do_open_tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord Cc: qemu-devel@nongnu.org, armbru@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com Am 06.06.2016 um 20:15 hat Colin Lord geschrieben: > Returns negative error codes and accompanying error messages in cases where > the device has no tray or the tray is locked and isn't forced open. This > extra information should result in better flexibility in functions that > call do_open_tray. > > Signed-off-by: Colin Lord > Suggested by: Markus Armbruster Thanks, updated the queued patch with this. As a minor remark, I think that having Suggested-by first is more common because it matches the chronological order: First someone suggested the change, then someone did the patch, and then someone merges it (that's my S-o-b that I add while applying the patch). For the same reason, I generally add Reviewed-by tags after the author's, but before my own maintainer S-o-b. Kevin