From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAFsD-00027M-G8 for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:12:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAFsB-0001s5-Ip for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:12:44 -0400 Date: Tue, 7 Jun 2016 14:12:34 +0200 From: Kevin Wolf Message-ID: <20160607121234.GF4684@noname.str.redhat.com> References: <1464973388-15821-1-git-send-email-eblake@redhat.com> <1464973388-15821-3-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464973388-15821-3-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/5] block: Honor flags during bdrv_aligned_preadv() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, mreitz@redhat.com, qemu-block@nongnu.org, Stefan Hajnoczi , Fam Zheng Am 03.06.2016 um 19:03 hat Eric Blake geschrieben: > Not that we pass any flags during reads yet, but we may want to > support BDRV_REQ_FUA on reads in the future. So don't throw > away the input flags. > > Signed-off-by: Eric Blake Do we want to pass flags to bdrv_co_do_copy_on_readv(), too? I guess we would use them for the preadv call there, but continue to use 0 as the pwritev flags. We may also want to introduce a .supported_read_flags, but perhaps this is not something to do in this patch. And we don't even use .supported_write_flags for drivers that have a native .bdrv_co_pwritev. Of course, that's even less related to this patch. I guess I should send a fix for that. Looks good otherwise. Kevin