* [Qemu-devel] [PATCH] scsi: megasas: null terminate bios version buffer
@ 2016-06-07 11:14 P J P
2016-06-07 11:54 ` Peter Maydell
2016-06-07 14:06 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: P J P @ 2016-06-07 11:14 UTC (permalink / raw)
To: Qemu Developers; +Cc: Paolo Bonzini, Li Qiang, Prasad J Pandit
From: Prasad J Pandit <pjp@fedoraproject.org>
While reading information via 'megasas_ctrl_get_info' routine,
a local bios version buffer isn't null terminated. Add the
terminating null byte to avoid any OOB access.
Reported-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/scsi/megasas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index cc66d36..a9ffc32 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -773,6 +773,7 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)
ptr = memory_region_get_ram_ptr(&pci_dev->rom);
memcpy(biosver, ptr + 0x41, 31);
+ biosver[31] = 0;
memcpy(info.image_component[1].name, "BIOS", 4);
memcpy(info.image_component[1].version, biosver,
strlen((const char *)biosver));
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] scsi: megasas: null terminate bios version buffer
2016-06-07 11:14 [Qemu-devel] [PATCH] scsi: megasas: null terminate bios version buffer P J P
@ 2016-06-07 11:54 ` Peter Maydell
2016-06-07 14:06 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2016-06-07 11:54 UTC (permalink / raw)
To: P J P; +Cc: Qemu Developers, Paolo Bonzini, Li Qiang, Prasad J Pandit
On 7 June 2016 at 12:14, P J P <ppandit@redhat.com> wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> While reading information via 'megasas_ctrl_get_info' routine,
> a local bios version buffer isn't null terminated. Add the
> terminating null byte to avoid any OOB access.
>
> Reported-by: Li Qiang <liqiang6-s@360.cn>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/scsi/megasas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index cc66d36..a9ffc32 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -773,6 +773,7 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)
>
> ptr = memory_region_get_ram_ptr(&pci_dev->rom);
> memcpy(biosver, ptr + 0x41, 31);
> + biosver[31] = 0;
> memcpy(info.image_component[1].name, "BIOS", 4);
> memcpy(info.image_component[1].version, biosver,
> strlen((const char *)biosver));
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] scsi: megasas: null terminate bios version buffer
2016-06-07 11:14 [Qemu-devel] [PATCH] scsi: megasas: null terminate bios version buffer P J P
2016-06-07 11:54 ` Peter Maydell
@ 2016-06-07 14:06 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2016-06-07 14:06 UTC (permalink / raw)
To: P J P; +Cc: Qemu Developers, Paolo Bonzini, Li Qiang, Prasad J Pandit
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Tue, Jun 07, 2016 at 04:44:03PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> While reading information via 'megasas_ctrl_get_info' routine,
> a local bios version buffer isn't null terminated. Add the
> terminating null byte to avoid any OOB access.
>
> Reported-by: Li Qiang <liqiang6-s@360.cn>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/scsi/megasas.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-07 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 11:14 [Qemu-devel] [PATCH] scsi: megasas: null terminate bios version buffer P J P
2016-06-07 11:54 ` Peter Maydell
2016-06-07 14:06 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).