From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAGBm-0001uh-6q for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAGBh-0005rD-AE for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:32:57 -0400 Date: Tue, 7 Jun 2016 14:32:44 +0200 From: Igor Mammedov Message-ID: <20160607143244.2d4ddb81@nial.brq.redhat.com> In-Reply-To: <934c1059-07ac-aed0-4ee5-c4bca138db55@redhat.com> References: <1465226212-254093-1-git-send-email-imammedo@redhat.com> <1465226212-254093-7-git-send-email-imammedo@redhat.com> <934c1059-07ac-aed0-4ee5-c4bca138db55@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, ehabkost@redhat.com, mark.cave-ayland@ilande.co.uk, blauwirbel@gmail.com, qemu-arm@nongnu.org, rth@twiddle.net On Tue, 7 Jun 2016 13:44:58 +0200 Paolo Bonzini wrote: > On 06/06/2016 17:16, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > target-i386/cpu.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index f791a06..31e5e6f 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -1975,6 +1975,9 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features, > > error_propagate(errp, local_err); > > return; > > } > > + fprintf(stderr, > > + "'+%s' is obsolete and will be removed in future, use '%s=on'", > > + featurestr + 1, featurestr + 1); > > Could you detect using +foo together with foo=off, and -foo together > with foo=on? Those are the really problematic cases, without them +foo > and -foo can become synonyms for =on and =off. That's (legacy)current semantic of -cpu +-foo where it overrides any foo=x, potentially it's possible to track foo=x locally in parser and then compare with +-foo both ways. But all we can do currently is to print warning about such use case. I think Eduardo's suggestion to just warn that +-foo is obsolete for now and drop support for it in several releases is sufficient(good) enough. > Paolo > > > continue; > > } else if (featurestr[0] == '-') { > > add_flagname_to_bitmaps(featurestr + 1, minus_features, &local_err); > > @@ -1982,6 +1985,9 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features, > > error_propagate(errp, local_err); > > return; > > } > > + fprintf(stderr, > > + "'-%s' is obsolete and will be removed in future, use '%s=off'", > > + featurestr + 1, featurestr + 1); > > continue; > > } > > > >