qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL v2 23/25] pc-dimm: get memory region from ->get_memory_region()
Date: Tue, 7 Jun 2016 15:58:14 +0300	[thread overview]
Message-ID: <20160607155814-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1465304171-10874-1-git-send-email-mst@redhat.com>

From: Xiao Guangrong <guangrong.xiao@linux.intel.com>

Curretly, the memory region of backed memory is all directly
mapped to guest's address space, however, it will be not true
for nvdimm device if we introduce nvdimm label which only can
be indirectly accessed by ACPI DSM method

Also it improves the comments a bit to reflect this fact

Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/mem/pc-dimm.h | 3 ++-
 hw/mem/pc-dimm.c         | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index 8cdc326..6024627 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -58,7 +58,8 @@ typedef struct PCDIMMDevice {
 
 /**
  * PCDIMMDeviceClass:
- * @get_memory_region: returns #MemoryRegion associated with @dimm
+ * @get_memory_region: returns #MemoryRegion associated with @dimm which
+ * is directly mapped into the physical address space of guest
  */
 typedef struct PCDIMMDeviceClass {
     /* private */
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 9e7de56..70b9451 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -354,8 +354,9 @@ static void pc_dimm_get_size(Object *obj, Visitor *v, const char *name,
     int64_t value;
     MemoryRegion *mr;
     PCDIMMDevice *dimm = PC_DIMM(obj);
+    PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(obj);
 
-    mr = host_memory_backend_get_memory(dimm->hostmem, errp);
+    mr = ddc->get_memory_region(dimm);
     value = memory_region_size(mr);
 
     visit_type_int(v, name, &value, errp);
-- 
MST

  parent reply	other threads:[~2016-06-07 12:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1465304171-10874-1-git-send-email-mst@redhat.com>
2016-06-07 12:56 ` [Qemu-devel] [PULL v2 01/25] tests: acpi: report names of expected files in verbose mode Michael S. Tsirkin
2016-06-07 12:56 ` [Qemu-devel] [PULL v2 02/25] acpi: add aml_debug() Michael S. Tsirkin
2016-06-07 12:56 ` [Qemu-devel] [PULL v2 03/25] acpi: add aml_refof() Michael S. Tsirkin
2016-06-07 12:56 ` [Qemu-devel] [PULL v2 04/25] pc: acpi: remove AML for empty/not used GPE handlers Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 05/25] pc: acpi: consolidate CPU hotplug AML Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 06/25] pc: acpi: consolidate \GPE._E02 with the rest of " Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 07/25] pc: acpi: cpu-hotplug: make AML CPU_foo defines local to cpu_hotplug_acpi_table.c Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 08/25] pc: acpi: mark current CPU hotplug functions as legacy Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 09/25] pc: acpi: consolidate legacy CPU hotplug in one file Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 10/25] pc: acpi: simplify build_legacy_cpu_hotplug_aml() signature Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 11/25] pc: acpi: cpuhp-legacy: switch ProcessorID to possible_cpus idx Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 12/25] tests: acpi: update tables with consolidated legacy cpu-hotplug AML Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 13/25] ipmi: rework the fwinfo to be fetched from the interface Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 14/25] pc: Postpone SMBIOS table installation to post machine init Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 15/25] acpi: extend ACPI interface to provide send_event hook Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 16/25] pc: use AcpiDeviceIfClass.send_event to issue GPE events Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 17/25] acpi: convert linker from GArray to BIOSLinker structure Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 18/25] acpi: simplify bios_linker API by removing redundant 'table' argument Michael S. Tsirkin
2016-06-07 12:57 ` [Qemu-devel] [PULL v2 19/25] acpi: cleanup bios_linker_loader_cleanup() Michael S. Tsirkin
2016-06-07 12:58 ` [Qemu-devel] [PULL v2 20/25] tpm: apci: cleanup TCPA table initialization Michael S. Tsirkin
2016-06-07 12:58 ` [Qemu-devel] [PULL v2 21/25] acpi: make bios_linker_loader_add_pointer() API offset based Michael S. Tsirkin
2016-06-07 12:58 ` [Qemu-devel] [PULL v2 22/25] acpi: make bios_linker_loader_add_checksum() " Michael S. Tsirkin
2016-06-07 12:58 ` Michael S. Tsirkin [this message]
2016-06-07 12:58 ` [Qemu-devel] [PULL v2 24/25] pc-dimm: introduce realize callback Michael S. Tsirkin
2016-06-07 12:58 ` [Qemu-devel] [PULL v2 25/25] virtio: move bi-endian target support to a single location Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607155814-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).