From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bAQyN-0002HC-Iu
	for qemu-devel@nongnu.org; Tue, 07 Jun 2016 20:03:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bAQyH-0003BL-Oy
	for qemu-devel@nongnu.org; Tue, 07 Jun 2016 20:03:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bAQyH-0003Af-JH
	for qemu-devel@nongnu.org; Tue, 07 Jun 2016 20:03:45 -0400
Date: Wed, 8 Jun 2016 08:03:39 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160608000339.GA8847@ad.usersys.redhat.com>
References: <1465228434-20143-1-git-send-email-ehabkost@redhat.com>
	<20160607032440.GC2273@ad.usersys.redhat.com>
	<CAFEAcA8aHrLccLzyFvKkuomNZPtYKux_kjRZYZKk-bLVTpagkg@mail.gmail.com>
	<CAFEAcA8xrMGxTMNsfCKYjcO=_ZdA6vupuKRJ--vq8sfzZ228mQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8xrMGxTMNsfCKYjcO=_ZdA6vupuKRJ--vq8sfzZ228mQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] docker: Don't use eval trick on Makefile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Tue, 06/07 15:30, Peter Maydell wrote:
> On 7 June 2016 at 15:00, Peter Maydell <peter.maydell@linaro.org> wrote:
> > On 7 June 2016 at 04:24, Fam Zheng <famz@redhat.com> wrote:
> >> On Mon, 06/06 12:53, Eduardo Habkost wrote:
> >>> The eval trick for defining DOCKER_SRC_COPY doesn't do anything
> >>> useful, as DOCKER_SRC_COPY is immediately expanded just after it
> >>> is defined, and CUR_TIME is already defined using ":=". Simply
> >>> define it using ":=" so it is evaluated only once.
> >>>
> >>> The eval trick was also triggering an weird error on Travis builds:
> >>>   qemu/tests/docker/Makefile.include:34: *** unterminated variable reference.  Stop.
> >>>
> >>> The issue is not easily reproducible (maybe it's a bug in some
> >>> versions of Make), but it is avoided if removing the eval trick.
> 
> > Hi; I'd like to apply this direct to master, because one of my build
> > test machines hits this error intermittently, and so without the fix
> > I can't reliably process any other pull requests.
> 
> Now applied, thanks.

No problem, sorry for the trouble!

Fam