Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

[Peter Xu <peterx@redhat.com>]

On Tue, Jun 07, 2016 at 10:32:34PM +0300, David Kiarie wrote:
> On Tue, Jun 7, 2016 at 10:12 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > Hi,
> 
> Hello,
> 
> >
> > I didn't review the amd_iommu.c code, but there seems to be some
> > unrelated changes in the patch:
> 
> Thanks for looking at this but I actually wanted someone to look at
> the amd_iommu.c. I mentioned in annotation that there are some
> unrelated changes because this work is based on code that has not been
> merged yet. I specifically sent this to have a review in amd_iommu.c
> not the details but the design. I have patchset that implements AMD
> IOMMU (translation only) which is implemented as a PCI device. It is
> however not possible to work on interrupt remapping without converting
> AMD IOMMU from a PCI device to a SysBusDevice. This device(AMD IOMMU),
> the one on this patch unlike in previous patches, creates to devices ;
> a PCI device and a SySBusDev which am not sure is acceptable.

I would suggest that you generate another patch, only contains the
changes you made related to adding the PCI device for AMD IOMMU,
explain bits about what this work is based on (e.g., IMHO it could be
based on your v11 AMD patchset and several other patches like Intel
IOMMU IR, just mention them in the cover letter), then mark it as a
RFC.

-- peterx