* [Qemu-devel] [PULL 1/6] tests/docker: fix make-archive-maybe
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
@ 2016-06-08 7:22 ` Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 2/6] tests/docker: make test-full build all targets, not none Fam Zheng
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2016-06-08 7:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
From: Paolo Bonzini <pbonzini@redhat.com>
make-archive-maybe expects an archive path relative
to $1, but receives a path relative to the current directory. Redirect
the output outside the subshell to bypass the "cd $1".
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-2-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/Makefile.include | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 134dc6f..f88c0a7 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -21,10 +21,10 @@ IMAGES ?= %
make-archive-maybe = $(if $(wildcard $1/*), \
$(call quiet-command, \
(cd $1; if git diff-index --quiet HEAD -- &>/dev/null; then \
- git archive -1 HEAD --format=tar.gz -o $2; \
+ git archive -1 HEAD --format=tar.gz; \
else \
- git archive -1 $$(git stash create) --format=tar.gz -o $2; \
- fi), \
+ git archive -1 $$(git stash create) --format=tar.gz; \
+ fi) > $2, \
" ARCHIVE $(notdir $2)"))
CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.$$$$)
--
2.8.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PULL 2/6] tests/docker: make test-full build all targets, not none
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 1/6] tests/docker: fix make-archive-maybe Fam Zheng
@ 2016-06-08 7:22 ` Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 3/6] tests/docker: fix test-mingw Fam Zheng
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2016-06-08 7:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
From: Paolo Bonzini <pbonzini@redhat.com>
Fix common.rc to avoid passing an empty --target-list= option to configure.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-3-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/common.rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index c493eeb..77069e1 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -24,7 +24,7 @@ requires()
build_qemu()
{
$QEMU_SRC/configure \
- --target-list="${TARGET_LIST}" \
+ ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
--prefix="$PWD/install" \
$EXTRA_CONFIGURE_OPTS \
"$@"
--
2.8.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PULL 3/6] tests/docker: fix test-mingw
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 1/6] tests/docker: fix make-archive-maybe Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 2/6] tests/docker: make test-full build all targets, not none Fam Zheng
@ 2016-06-08 7:22 ` Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 4/6] tests/docker: remove unused feature "ccache" Fam Zheng
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2016-06-08 7:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
From: Paolo Bonzini <pbonzini@redhat.com>
Add flex and bison for use in test-mingw, because test-mingw
uses the in-tree libdtc.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-4-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 2 +-
tests/docker/dockerfiles/ubuntu.docker | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 6251e45..76acff3 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,6 +1,6 @@
FROM fedora:23
RUN dnf install -y \
- ccache git tar \
+ ccache git tar flex bison \
glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
gcc gcc-c++ clang make perl which bc findutils \
mingw{32,64}-{pixman,glib2,gmp,SDL,pkg-config,gtk2,gtk3,gnutls,nettle,libtasn1,libjpeg-turbo,libpng,curl,libssh2,bzip2}
diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker
index 725a7ca..44ecc12 100644
--- a/tests/docker/dockerfiles/ubuntu.docker
+++ b/tests/docker/dockerfiles/ubuntu.docker
@@ -2,7 +2,7 @@ FROM ubuntu:14.04
RUN echo "deb http://archive.ubuntu.com/ubuntu/ trusty universe multiverse" >> \
/etc/apt/sources.list
RUN apt-get update
-RUN apt-get -y install \
+RUN apt-get -y install flex bison \
libusb-1.0-0-dev libiscsi-dev librados-dev libncurses5-dev \
libseccomp-dev libgnutls-dev libssh2-1-dev libspice-server-dev \
libspice-protocol-dev libnss3-dev libfdt-dev \
--
2.8.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PULL 4/6] tests/docker: remove unused feature "ccache"
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
` (2 preceding siblings ...)
2016-06-08 7:22 ` [Qemu-devel] [PULL 3/6] tests/docker: fix test-mingw Fam Zheng
@ 2016-06-08 7:22 ` Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 5/6] tests/docker: support travis test with fedora image Fam Zheng
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2016-06-08 7:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
From: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-5-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/dockerfiles/ubuntu.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker
index 44ecc12..a8b88c3 100644
--- a/tests/docker/dockerfiles/ubuntu.docker
+++ b/tests/docker/dockerfiles/ubuntu.docker
@@ -8,4 +8,4 @@ RUN apt-get -y install flex bison \
libspice-protocol-dev libnss3-dev libfdt-dev \
libgtk-3-dev libvte-2.90-dev libsdl1.2-dev libpng12-dev libpixman-1-dev \
git make ccache python-yaml gcc clang sparse
-ENV FEATURES clang ccache pyyaml
+ENV FEATURES clang pyyaml
--
2.8.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PULL 5/6] tests/docker: support travis test with fedora image
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
` (3 preceding siblings ...)
2016-06-08 7:22 ` [Qemu-devel] [PULL 4/6] tests/docker: remove unused feature "ccache" Fam Zheng
@ 2016-06-08 7:22 ` Fam Zheng
2016-06-08 7:22 ` [Qemu-devel] [PULL 6/6] tests/docker: build all targets in test-clang Fam Zheng
2016-06-08 16:16 ` [Qemu-devel] [PULL 0/6] docker queue Peter Maydell
6 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2016-06-08 7:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
From: Paolo Bonzini <pbonzini@redhat.com>
Install sparse and PyYAML.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-6-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 76acff3..1d26a8e 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,7 +1,7 @@
FROM fedora:23
RUN dnf install -y \
- ccache git tar flex bison \
+ ccache git tar PyYAML sparse flex bison \
glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
gcc gcc-c++ clang make perl which bc findutils \
mingw{32,64}-{pixman,glib2,gmp,SDL,pkg-config,gtk2,gtk3,gnutls,nettle,libtasn1,libjpeg-turbo,libpng,curl,libssh2,bzip2}
-ENV FEATURES mingw clang
+ENV FEATURES mingw clang pyyaml
--
2.8.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PULL 6/6] tests/docker: build all targets in test-clang
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
` (4 preceding siblings ...)
2016-06-08 7:22 ` [Qemu-devel] [PULL 5/6] tests/docker: support travis test with fedora image Fam Zheng
@ 2016-06-08 7:22 ` Fam Zheng
2016-06-08 16:16 ` [Qemu-devel] [PULL 0/6] docker queue Peter Maydell
6 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2016-06-08 7:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
From: Paolo Bonzini <pbonzini@redhat.com>
Warnings specific to clang may affect devices that are not build by
x86_64-softmmu and aarch64-softmmu. Build all targets since that
is also what Peter does.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-7-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/test-clang | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/docker/test-clang b/tests/docker/test-clang
index 6745dbe..60e4e97 100755
--- a/tests/docker/test-clang
+++ b/tests/docker/test-clang
@@ -20,7 +20,5 @@ OPTS="--enable-debug --cxx=clang++ --cc=clang --host-cc=clang"
# See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
#OPTS="$OPTS --extra-cflags=-fsanitize=undefined \
#--extra-cflags=-fno-sanitize=float-divide-by-zero"
-DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"
-TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
build_qemu $OPTS
make $MAKEFLAGS check
--
2.8.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PULL 0/6] docker queue
2016-06-08 7:22 [Qemu-devel] [PULL 0/6] docker queue Fam Zheng
` (5 preceding siblings ...)
2016-06-08 7:22 ` [Qemu-devel] [PULL 6/6] tests/docker: build all targets in test-clang Fam Zheng
@ 2016-06-08 16:16 ` Peter Maydell
6 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2016-06-08 16:16 UTC (permalink / raw)
To: Fam Zheng; +Cc: QEMU Developers
On 8 June 2016 at 08:22, Fam Zheng <famz@redhat.com> wrote:
> The following changes since commit 6ed5546fa7bf12c5b87ef76bafb86e1d77ed6e85:
>
> Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2016-06-07' into staging (2016-06-07 16:34:45 +0100)
>
> are available in the git repository at:
>
> git://github.com/famz/qemu tags/pull-docker-20160608
>
> for you to fetch changes up to d3a49cbed5c18dcdce35f8e39712545ab1fd7cd0:
>
> tests/docker: build all targets in test-clang (2016-06-08 15:19:30 +0800)
>
> ----------------------------------------------------------------
> Docker testing fixes by Paolo.
>
> ----------------------------------------------------------------
> Paolo Bonzini (6):
> tests/docker: fix make-archive-maybe
> tests/docker: make test-full build all targets, not none
> tests/docker: fix test-mingw
> tests/docker: remove unused feature "ccache"
> tests/docker: support travis test with fedora image
> tests/docker: build all targets in test-clang
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread