From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAXso-0007Bi-LZ for qemu-devel@nongnu.org; Wed, 08 Jun 2016 03:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAXsk-0006qy-FM for qemu-devel@nongnu.org; Wed, 08 Jun 2016 03:26:33 -0400 Date: Wed, 8 Jun 2016 17:24:59 +1000 From: David Gibson Message-ID: <20160608072459.GB9226@voom.fritz.box> References: <1465313980-31281-1-git-send-email-thuth@redhat.com> <1465313980-31281-5-git-send-email-thuth@redhat.com> <20160608054448.GV9226@voom.fritz.box> <5757C252.8030803@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/w6WUUxYkubDgwa5" Content-Disposition: inline In-Reply-To: <5757C252.8030803@redhat.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] ppc: Improve PCR bit selection in ppc_set_compat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --/w6WUUxYkubDgwa5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 08, 2016 at 08:59:30AM +0200, Thomas Huth wrote: > On 08.06.2016 07:44, David Gibson wrote: > > On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: > >> When using an olderr PowerISA level, all the upper compatibility > >> bits have to be enabled, too. For example when we want to run > >> something in PowerISA 2.05 compatibility mode on POWER8, the bit > >> for 2.06 has to be set beside the bit for 2.05. > >> Additionally, to make sure that we do not set bits that are not > >> supported by the host, we apply a mask with the known-to-be-good > >> bits here, too. > >> > >> Signed-off-by: Thomas Huth > >=20 > > So, this breaks compile on 32-bit targets, because the spr values are > > only 32-bit there, and the PCR constants exceed that. But > > ppc_set_compat() is only actually used on 64-bit machines, so I've > > added a change to #if it out for 64-bit targets. >=20 > D'oh, I explicitly compiled everything with a mingw32 cross-compiler to > catch such issues ... but apparently it compiled without -Werror here, > so I did not notice the warning :-( No, not 32-bit *host*, 32-bit *target*, so mingw32 wouldn't help. Configuring in ppc-softmmu and ppcemb-softmmu would. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --/w6WUUxYkubDgwa5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXV8hLAAoJEGw4ysog2bOSzNEQALkQihA5wqSp4isudsm9Cz0e NoYdTEODF4ORVJx91iDwEpYSYcAbVtsf+V0mlTmkp4/ohpr0I9yt3HLsAeLGc6Uk fedvQsse5DwU6FixjaJmhf1x0OXsiz5A2y4SaEPz5Y3nfni88VLHQ4djpJ1Jpkx3 OSxhpvo9x1fPJuFbC9INgNTyOs58zuzS/yjq/oNA5p3kaJi1P4V0/+UxbVcBHt8q th4HDNPX/hm3RqXaxEMtML7l9Zt4IdsEBB4MmPlJJX9nDuzOY5QnttsfYAWHKMfg ESevjtaYqDlUH8nj6kVztNgefhxqB010rWEqCmNTjR9oyhc1dfvhbXMSyqjpPnZV ZhbiEpXJujAvael/JPwc+PUAxDR7W1HCHDu0WQzPgUO/0SOtO6StjXknEOYYSnqx 3pWbEdJHt2YDeXtIHP8qSKHmoxbyMpt2scYj/eB33z1r604LSV+Md8M3EawpGSjp 6pD82NBbUBW006WF3UwiFKY6B2K3w7J/pMtPiMclBxe7WoYRGo0dtuA0I1QkL/5p LAhZBmIeDKgJCOTIcOZMTulMEmsoOf9260tdUjhJEfNnw0GfA8XWVirExgUgONQL JZpig1zxjeIXtDxEQnd/dgn7NYxz2do38pY8dy55e5h3MUe554h9JyodqVXsue04 QcDcECeOZkZORVmUP5ZT =Ckzb -----END PGP SIGNATURE----- --/w6WUUxYkubDgwa5--