From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bAZ7U-0004v1-Gg
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 04:45:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bAZ7O-0000tW-RA
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 04:45:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50048)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bAZ7O-0000tR-A8
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 04:45:42 -0400
Date: Wed, 8 Jun 2016 09:45:37 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160608084537.GB7760@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1465373606-18486-1-git-send-email-thuth@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1465373606-18486-1-git-send-email-thuth@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW
 builds, too
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Yuri Pudgorodskiy <yur@virtuozzo.com>

On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
> MinGW seems to compile currently without warnings, so it should
> be safe to enable -Werror now for this environment, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  ... at least it compiles without errors for me here. I hope that's
>  also true for different versions of MinGW ... would be great if
>  everybody who has such a compiler installed could give it a try!

Heh, I have created exactly the same patch locally myself a few
months back after noticed that Mingw was now warning-free. I
never got around to sending it for some reason :-) I confirm that
it is still warning free today, on Fedora 23, x86_64 host.

> 
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 4627d2c..2e5b818 100755
> --- a/configure
> +++ b/configure
> @@ -1393,7 +1393,7 @@ z_version=$(cut -f3 -d. $source_path/VERSION)
>  
>  if test -z "$werror" ; then
>      if test -d "$source_path/.git" -a \
> -        "$linux" = "yes" ; then
> +        \( "$linux" = "yes" -o "$mingw32" = "yes" \) ; then
>          werror="yes"
>      else
>          werror="no"

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|