From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAbag-0008K9-6M for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAbaa-0007N2-Ka for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:24:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAbaa-0007MT-F4 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:24:00 -0400 Date: Wed, 8 Jun 2016 13:23:57 +0200 From: Kevin Wolf Message-ID: <20160608112357.GD5324@noname.str.redhat.com> References: <1465378757-15271-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465378757-15271-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy , Paolo Bonzini Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: > From: Vladimir Sementsov-Ogievskiy > > Acquire aio context before run command, this is mandatory for unit tests. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Paolo Bonzini Looks right to me, but why "mandatory for unit tests"? Does this fix an observable bug in unit tests? If so, we should be more specific in the commit message. But in fact, I would only expect it to make a difference for dataplane and I don't think we have test cases that use both the 'qemu-io' HMP command and dataplane. Kevin