From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAeEA-0001mn-CN for qemu-devel@nongnu.org; Wed, 08 Jun 2016 10:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAeE8-0008Ff-Rh for qemu-devel@nongnu.org; Wed, 08 Jun 2016 10:13:02 -0400 Date: Wed, 8 Jun 2016 15:12:54 +0100 From: Stefan Hajnoczi Message-ID: <20160608141254.GA3634@stefanha-x1.localdomain> References: <1465307797-28378-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline In-Reply-To: <1465307797-28378-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Don't emulate natively supported pwritev flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, eblake@redhat.com, famz@redhat.com, qemu-devel@nongnu.org --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2016 at 03:56:37PM +0200, Kevin Wolf wrote: > Drivers that implement .bdrv_co_pwritev() get the flags passed as an > argument to said function, but we also unconditionally emulate the flags > anyway. We shouldn't do that. >=20 > Fix this by clearing all flags that the driver supports natively after > it returns from .bdrv_co_pwritev(). >=20 > Fixes: 4df863f3 ('block: Make supported_write_flags a per-bds property') > Signed-off-by: Kevin Wolf > --- > block/io.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXWCfmAAoJEJykq7OBq3PI7ewIAKR3eO+Ziaox1FAdnXoSfeBw pMY0O+05HV69lmdQYT8V5QTzNMfUFPSWvAuKqV7I99BRHe77QLAvoqgauOt0KOUU qiTM2N8+Q+NYXcVWoTD6a6NqeSd/Aw4XDAlUBUx4KcydT2jlyfhzP/kzbRBGJsvG fsyaasmUqiYNr4kLuK+wxwpeOi8nIQslwVncF5dmY9gbw2uvCzPI/5OjFRATjcnL vlOWX6TrQtOEG10/0+ov3oyR+0J/QeYizRMlQ0CbDNY0gC9t7JomNkzCGsQQyT+v E/JrbiYgrKgt/Jkx0d1NMQ7iPbFJJKE/HL1xn/pGvghT2YE4XXDSXWvwDk9CybM= =m2fo -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT--