From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBGHC-0003UJ-7f for qemu-devel@nongnu.org; Fri, 10 Jun 2016 02:50:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBGH6-00036P-4o for qemu-devel@nongnu.org; Fri, 10 Jun 2016 02:50:41 -0400 Date: Fri, 10 Jun 2016 14:04:41 +1000 From: David Gibson Message-ID: <20160610040441.GM9226@voom.fritz.box> References: <1465520348-13964-1-git-send-email-bharata@linux.vnet.ibm.com> <1465520348-13964-2-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S4au6D4xuhGIk15i" Content-Disposition: inline In-Reply-To: <1465520348-13964-2-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 1/9] qom: API to get instance_size of a type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, imammedo@redhat.com, thuth@redhat.com, aik@ozlabs.ru, agraf@suse.de, pbonzini@redhat.com, ehabkost@redhat.com, pkrempa@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com, mjrosato@linux.vnet.ibm.com, borntraeger@de.ibm.com --S4au6D4xuhGIk15i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2016 at 06:29:00AM +0530, Bharata B Rao wrote: > Add an API object_type_get_size(const char *typename) that returns the > instance_size of the give typename. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson This looks sensible to me, it would be nice to have an ack or two from the qemu community at large. > --- > include/qom/object.h | 8 +++++++- > qom/object.c | 8 ++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/include/qom/object.h b/include/qom/object.h > index 21bb5ff..460ddfc 100644 > --- a/include/qom/object.h > +++ b/include/qom/object.h > @@ -1608,5 +1608,11 @@ int object_child_foreach_recursive(Object *obj, > */ > Object *container_get(Object *root, const char *path); > =20 > - > +/** > + * object_type_get_size: > + * @typename: Name of the Type whose instance_size is required > + * > + * Returns the instance_size of the given @typename. > + */ > +size_t object_type_get_size(const char *typename); > #endif > diff --git a/qom/object.c b/qom/object.c > index 3bc8a00..0e75877 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -202,6 +202,14 @@ static size_t type_object_get_size(TypeImpl *ti) > return 0; > } > =20 > +size_t object_type_get_size(const char *typename) > +{ > + TypeImpl *type =3D type_get_by_name(typename); > + > + g_assert(type !=3D NULL); > + return type_object_get_size(type); > +} > + > static bool type_is_ancestor(TypeImpl *type, TypeImpl *target_type) > { > assert(target_type); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --S4au6D4xuhGIk15i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXWjxZAAoJEGw4ysog2bOSZB0P/Rf++529SEpw9KwYvpie2qPy SObzqXjjglZ+QpVXbz8lu4ACZfhMn2sqEtEL7QBvw8E7kDK6iBCsvnEtebD/3hhv O1d/sB/R/+TXS7M2mVz4ekhB5F+QosqCA+XdJI0PGzsblzgJGyRv7Iq05MBqhBe5 kHzda20QYasLxGPL8/jOmn81lpKSQyx7yTyi0QAJTbfYUhlDGw7o3jS5OMUT2RSP CLn5gr6heMIYqnitqOmP1kdvak6KQcm6POhUQCPhJWrRXOD3s6MLJAp41TXdzo3H lD410ShsztZWNawuyexXEYb23N2tqh2xIgv0atWE/bYQ2yRozYbllXvs1wtueTjK EetSfEG61xneb25shFfq9HqW+F3Xy/CG2NO3xlkHWfdtQl6vHYKOwYPeqRurL+MX G0wqMnw4rjBn3risjQux+Lm/JMfK9xxz4+QnxUpVfXHm/S2aCx1U09Ot0ww9C9p2 6OdtzU1RlC/+es9EXo6I5gaj0Smd9EUogPyLZ+GTtop4+4m6tL/w1jvdI2DgxX7j hutjn9k4dbvPcWH5Cqa8nrzqu4YP55HB/VDJ7rW9Pq/CE4eRpx6MDjhT1INEYmQj FfElQRzVBaSr5Zrbwlq4CPtT6AGSEMRP4agwEOQGD1c1QhonQz7nu/bqrvraAtOm fW/D9jrU5rjKcRkByz9C =ctSK -----END PGP SIGNATURE----- --S4au6D4xuhGIk15i--