From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBGHD-0003UQ-FD for qemu-devel@nongnu.org; Fri, 10 Jun 2016 02:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBGH6-00036p-E5 for qemu-devel@nongnu.org; Fri, 10 Jun 2016 02:50:42 -0400 Date: Fri, 10 Jun 2016 15:14:14 +1000 From: David Gibson Message-ID: <20160610051414.GP9226@voom.fritz.box> References: <1465520348-13964-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8+74qwmUvVX309i6" Content-Disposition: inline In-Reply-To: <1465520348-13964-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 0/9] Core based CPU hotplug for PowerPC sPAPR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, imammedo@redhat.com, thuth@redhat.com, aik@ozlabs.ru, agraf@suse.de, pbonzini@redhat.com, ehabkost@redhat.com, pkrempa@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com, mjrosato@linux.vnet.ibm.com, borntraeger@de.ibm.com --8+74qwmUvVX309i6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2016 at 06:28:59AM +0530, Bharata B Rao wrote: > Hi, >=20 > This is the next version of the CPU hotplug patchset for PowerPC > sPAPR target. The hotplug semantics looks like this: >=20 > (qemu) device_add POWER8E-spapr-cpu-core,id=3Dcore2,core-id=3D16[,threads= =3D4] > (qemu) device_add host-spapr-cpu-core,id=3Dcore2,core-id=3D16[,threads=3D= 4] > (qemu) device_add > POWER8E_v2.1-spapr-cpu-core,id=3Dcore2,core-id=3D16[,threads=3D4] I've merged these to my ppc-cpu-hotplug branch, and I'm doing some testing. It it checks out, I hope to send a pull request. >=20 > Changes in v4 > ------------- > - Rebased against David Gibson's ppc-cpu-hotplug and hence dropped those > patches that are already part of that tree. > - We were assuming the CPU thread to be always of type PowerPCCPU which > needn't be true. Hence use actual CPU type's instance_size when > object_initialize'ing the threads as per David's suggestion. This requi= res > us to know the instance_size for a given type for which a new QOM API > object_type_get_size() has been introduced in this version. > - Consolidate CPU init related routines in spapr_cpu_core.c. As part of t= his > move spapr_cpu_init() and its dependencies to spapr_cpu_core.c. > - Got rid of the temporary unplug list when removing CPU cores. > - Folded spapr_cpu_core_create_threads() into spapr_cpu_core_realize() and > fixed the error path in in spapr_cpu_core_realize(). > - Add support for -cpu host. >=20 > TODOs remaining > --------------- > - Work on David's suggestion of intializing CPU's ObjectClass in > class_init rather than instance_init. > - Use object_initialize_with_type instead of object_initialize when > creating CPU threads of a core. > - Use vcpu_dt_id logic when populating core id in > spapr_query_hotpluggable_cpus(). > - Handle CPU compat properly (-cpu host,compat=3DPOWER7) >=20 > v3: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg01829.html >=20 > Bharata B Rao (7): > qom: API to get instance_size of a type > spapr: Abstract CPU core device and type specific core devices > spapr: Move spapr_cpu_init() to spapr_cpu_core.c > spapr: convert boot CPUs into CPU core devices > spapr: CPU hotplug support > spapr: CPU hot unplug support > hmp: Add 'info hotpluggable-cpus' HMP command >=20 > Igor Mammedov (2): > QMP: Add query-hotpluggable-cpus > spapr: implement query-hotpluggable-cpus callback >=20 > hmp-commands-info.hx | 14 ++ > hmp.c | 41 ++++ > hmp.h | 1 + > hw/ppc/Makefile.objs | 1 + > hw/ppc/spapr.c | 215 +++++++++++++++------ > hw/ppc/spapr_cpu_core.c | 405 ++++++++++++++++++++++++++++++++++= ++++++ > hw/ppc/spapr_events.c | 3 + > hw/ppc/spapr_rtas.c | 24 +++ > include/hw/boards.h | 5 + > include/hw/ppc/spapr.h | 7 + > include/hw/ppc/spapr_cpu_core.h | 36 ++++ > include/qom/object.h | 8 +- > monitor.c | 13 ++ > qapi-schema.json | 55 ++++++ > qmp-commands.hx | 23 +++ > qom/object.c | 8 + > target-ppc/kvm.c | 28 +++ > 17 files changed, 828 insertions(+), 59 deletions(-) > create mode 100644 hw/ppc/spapr_cpu_core.c > create mode 100644 include/hw/ppc/spapr_cpu_core.h >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8+74qwmUvVX309i6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXWkylAAoJEGw4ysog2bOSQroQAI2c7VhGZe1Xo/vNjfOxYAhm oynHoXeTi8msgaHTnMOpDuaovNI8v2OsTg88EocP+bbJtUA3EmoiFKNiX/oZoUNT 3c7BN6hlow6nEAuG0FE588f/ZFovN7frLzibruf2tsb3h9zNwsskZGrI5M2xVw4p YoQthb4HaM7prAyc41zbEUvILP4P4jpe9G2i0rDVTm+G2AWuBVBwmLvleG8ws/ri OIKLHiNILbg51Xbu6N8IZJnkECRxToO28anyTWcV7uIC5qPVfkCp9KjaXK+7wqae uZLPNZP6amDHmt9xkJQEokxDOeWQizbTLU1zKLGD9D877fO/Wab5fwewAf1a0JJd dYV6aF7iRe3HkDHAHRMHhakH0q6PjCBTlk8SIlhW6sG6cXLPT+wIk5TskiB0wWOl EeU5M1SeGA4nVsiTcYALsFmzK2Ho/Cku/n78x255Go7jGQIC4IZUcHTuaz7AF8bD Yjd369eBsrE0uGLCCgHTzIhyOL9NT9F/O8AsFvjoD2Q8rgFcIskiZjpvLTZYhDv/ LZDR5k7+CNtFvALamFJDunO2rxE1bjxzcUdRtPFjNK+Q4ZgZGvSURQ60mtOQEvrM OkydDM29GiN4nEGMu857JuWh4maKp3SjToOzKoaFCTNZfOGxf9WaXsWZDakqfmP/ pHlP7WK2VMIfGmbCmF0x =oC33 -----END PGP SIGNATURE----- --8+74qwmUvVX309i6--