From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1bBQZH-00066G-Ds
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 13:50:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1bBQZB-0002y3-Gi
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 13:50:02 -0400
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <1465572354-3083-1-git-send-email-thuth@redhat.com>
References: <1465572354-3083-1-git-send-email-thuth@redhat.com>
Message-ID: <20160610174740.665.66463@loki>
Date: Fri, 10 Jun 2016 12:47:40 -0500
Subject: Re: [Qemu-devel] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into
 CONFIG_QGA_NTDDSCSI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org

Quoting Thomas Huth (2016-06-10 10:25:54)
> There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU
> sources. Looking at the changelog and qga/commands-win32.c, it
> seems like this should be called CONFIG_QGA_NTDDSCSI instead.
> =

> Signed-off-by: Thomas Huth <thuth@redhat.com>

Yikes, this does appear to be the case. Need to recheck the original
functionality since apparently it's been disabled ever since I added
this patch to the original series, but can take this in through my
tree.

Cc'ing qemu-stable

> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/configure b/configure
> index 8c2f90b..55019d6 100755
> --- a/configure
> +++ b/configure
> @@ -4965,7 +4965,7 @@ if test "$mingw32" =3D "yes" ; then
>      echo "WIN_SDK=3D\"$win_sdk\"" >> $config_host_mak
>    fi
>    if test "$guest_agent_ntddscsi" =3D "yes" ; then
> -    echo "CONFIG_QGA_NTDDDISK=3Dy" >> $config_host_mak
> +    echo "CONFIG_QGA_NTDDSCSI=3Dy" >> $config_host_mak
>    fi
>    if test "$guest_agent_msi" =3D "yes"; then
>      echo "QEMU_GA_MSI_ENABLED=3Dyes" >> $config_host_mak  =

> -- =

> 1.8.3.1
>=20