From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBRnw-0007Uc-Qz for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:09:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBRnr-0003Rz-Nt for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:09:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBRnr-0003Rv-FR for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:09:11 -0400 Date: Fri, 10 Jun 2016 20:09:06 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160610190906.GC2258@work-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 0/8] migration: fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Amit Shah , Juan Quintela , "Daniel P. Berrange" , qemu list * Peter Maydell (peter.maydell@linaro.org) wrote: > On 10 June 2016 at 14:25, Peter Maydell wrote: > > On 10 June 2016 at 12:48, Amit Shah wrote: > >> > >> The following changes since commit 0c33682d5f29b0a4ae53bdec4c8e52e4fae37b34: > >> > >> target-i386: Move user-mode exception actions out of user-exec.c (2016-06-09 15:55:02 +0100) > >> > >> are available in the git repository at: > >> > >> https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/migration-for-2.7-3 > >> > >> for you to fetch changes up to cfac638acf903f7618b285dc3f36de348554c8ad: > >> > >> Postcopy: Check for support when setting the capability (2016-06-10 17:13:32 +0530) > >> > >> ---------------------------------------------------------------- > >> Migration: > >> > >> - Fixes for TLS series > >> - Postcopy: Add stats, fix, test case > >> > >> ---------------------------------------------------------------- > > > > Fails to build on OSX > > Also fails to build on AArch64 Linux: OK, I see why I missed this. My two weirder build cases I checked with previously were building on RHEL6 (that's too old for userfault) and an ARM box. However, the tests include the headers from qemu's linux-header/ subdirectory and that includes __NR_userfault for both x86 and 32bit ARM, so I wasn't hitting the other side of the ifdef in my testing. Dave > > /home/petmay01/qemu/tests/postcopy-test.c: In function 'return_or_event': > /home/petmay01/qemu/tests/postcopy-test.c:177:9: error: 'got_stop' > undeclared (first use in this function) > got_stop = true; > ^ > /home/petmay01/qemu/tests/postcopy-test.c:177:9: note: each undeclared > identifier is reported only once for each function it appears in > /home/petmay01/qemu/tests/postcopy-test.c: In function > 'wait_for_migration_pass': > /home/petmay01/qemu/tests/postcopy-test.c:235:13: error: 'got_stop' > undeclared (first use in this function) > if (got_stop || initial_pass) { > ^ > /home/petmay01/qemu/tests/postcopy-test.c: In function 'check_guests_ram': > /home/petmay01/qemu/tests/postcopy-test.c:262:33: error: > 'start_address' undeclared (first use in this function) > qtest_memread(global_qtest, start_address, &first_byte, 1); > ^ > /home/petmay01/qemu/tests/postcopy-test.c:265:52: error: 'end_address' > undeclared (first use in this function) > for (address = start_address + 4096; address < end_address; > address += 4096) > ^ > /home/petmay01/qemu/tests/postcopy-test.c: In function 'test_migrate': > /home/petmay01/qemu/tests/postcopy-test.c:307:5: error: 'got_stop' > undeclared (first use in this function) > got_stop = false; > ^ > /home/petmay01/qemu/tests/postcopy-test.c:395:23: error: > 'start_address' undeclared (first use in this function) > qtest_memread(to, start_address, &dest_byte_a, 1); > ^ > > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK