* [Qemu-devel] [PATCH] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
@ 2016-06-12 22:19 Sean Bruno
2016-06-13 0:32 ` Fam Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Sean Bruno @ 2016-06-12 22:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Sean Bruno
The --quiet argument is not available on all operating systems. Use -s
instead to match the rest of the Makefile uses. This fixes a non-fatal
error see on FreeBSD.
Signed-off-by: Sean Bruno <sbruno@freebsd.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ed4032a..a7a356a 100644
--- a/Makefile
+++ b/Makefile
@@ -185,7 +185,7 @@ qemu-version.h: FORCE
printf '""\n'; \
fi; \
fi) > $@.tmp)
- $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
+ $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
config-host.h: config-host.h-timestamp
config-host.h-timestamp: config-host.mak
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
2016-06-12 22:19 [Qemu-devel] [PATCH] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
@ 2016-06-13 0:32 ` Fam Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Fam Zheng @ 2016-06-13 0:32 UTC (permalink / raw)
To: Sean Bruno; +Cc: qemu-devel
On Sun, 06/12 15:19, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error see on FreeBSD.
s/see/seen
(Perhaps can be fixed when applying.)
Reviewed-by: Fam Zheng <famz@redhat.com>
>
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
> config-host.h: config-host.h-timestamp
> config-host.h-timestamp: config-host.mak
> --
> 2.8.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-13 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-12 22:19 [Qemu-devel] [PATCH] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
2016-06-13 0:32 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).