From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCJea-0000R1-FO for qemu-devel@nongnu.org; Mon, 13 Jun 2016 00:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCJeV-0002KV-Hi for qemu-devel@nongnu.org; Mon, 13 Jun 2016 00:39:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCJeV-0002KQ-Bf for qemu-devel@nongnu.org; Mon, 13 Jun 2016 00:39:07 -0400 Date: Mon, 13 Jun 2016 10:08:53 +0530 From: Amit Shah Message-ID: <20160613043853.GE6398@grmbl.mre> References: <1465574962-2710-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465574962-2710-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH v2] migration: Don't use *_to_cpup() and cpu_to_*w() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org, Juan Quintela , Eric Blake On (Fri) 10 Jun 2016 [17:09:22], Peter Maydell wrote: > The *_to_cpup() and cpu_to_*w() functions just compose a pointer > dereference with a byteswap. Instead use ld*_p() and st*_p(), > which handle potential pointer misalignment and avoid the need > to cast the pointer. > > Signed-off-by: Peter Maydell Reviewed-by: Amit Shah I'll pick this up, thanks. Amit