From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCS96-0003j6-Ow for qemu-devel@nongnu.org; Mon, 13 Jun 2016 09:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCS95-0007oK-OW for qemu-devel@nongnu.org; Mon, 13 Jun 2016 09:43:16 -0400 Date: Mon, 13 Jun 2016 15:43:06 +0200 From: Kevin Wolf Message-ID: <20160613134306.GC5968@noname.str.redhat.com> References: <1465395011-26088-1-git-send-email-kwolf@redhat.com> <20160613132722.GQ27781@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20160613132722.GQ27781@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH 0/6] block: Enable byte granularity I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-block@nongnu.org, eblake@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, famz@redhat.com, qemu-devel@nongnu.org --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 13.06.2016 um 15:27 hat Stefan Hajnoczi geschrieben: > On Wed, Jun 08, 2016 at 04:10:05PM +0200, Kevin Wolf wrote: > > Previous series have already converted some block drivers to byte-based= rather > > than sector-based interfaces. However, the common I/O path as well as r= aw-posix > > still enforced a minimum alignment of 512 bytes because some sector-bas= ed logic > > was involved. > >=20 > > This patch series removes these limitations and a sub-sector request ac= tually > > ends up as a sub-sector syscall now. > >=20 > > Kevin Wolf (6): > > block: Byte-based bdrv_co_do_copy_on_readv() > > block: Prepare bdrv_aligned_preadv() for byte-aligned requests > > block: Prepare bdrv_aligned_pwritev() for byte-aligned requests > > raw-posix: Switch to bdrv_co_* interfaces > > raw-posix: Implement .bdrv_co_preadv/pwritev > > block: Don't enforce 512 byte minimum alignment > >=20 > > block.c | 2 +- > > block/io.c | 125 +++++++++++++++++++++++++-----------------= -------- > > block/linux-aio.c | 83 ++++++++++++++++++++++++--------- > > block/mirror.c | 10 ++-- > > block/raw-aio.h | 2 + > > block/raw-posix.c | 61 ++++++++++++------------ > > include/block/block.h | 10 ++-- > > 7 files changed, 169 insertions(+), 124 deletions(-) >=20 > I've taken an initial look and it looks good. Will review next revision > in depth so it can be merged after Eric's comments have been addressed. Eric commented a lot, but only requested very few minor changes that wouldn't strictly require resending the series. If you think it's worthwhile to send a v2 for them, I can do that, but it shouldn't make a big difference for your review. Kevin --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXXrhqAAoJEH8JsnLIjy/WI/4P/RKT/dGg6bA3x+CU3JRQJHFI fHtaQ/zGkL600HBk74E31JG8/tdvYgzphKDnqE8Mqb34GG3QStrzcuGKFVvfzxM2 AvoBuQrbJk6+hQEg96bvVLW7RCD4g+Wb2WEQRLoI+D3RLCHLu/NmYFtgyWozS1YW xP/lbiqKqh53OtVuLqeEJvQefBRmMPlzWwjDMcEqnIDKd1jIyRUEowkU/1m3J29g 8Q/CZChUqxP8BRAIGh266vSSm7pXxw6goh8so447YAS33iIcPryAldcFh8Q+wgZB oSe6JhBxhD/y2xf8Xr12/YxFYevAMUEwhgr4cdUS+FjQFcO7ckOomV+gb4rK4M+B w8DXECeJgNhT0Z312HKI/OnXXjVQJe8hyAP+WeSEEfDl1QYMQRaS5HWzN/LkVPNq kxY7MZmx/kOfMptwCq6QvgM8e0vheGJzUavM1PSq7lCNu9pp2NjFBQL1M2Fr9VtS xcND3sVzK4miuBUQxtZeD2R1DB+fGvngiAjQJ+8LdKocGFwMKAhmjdCXpAnqCjEn ysZJdTUz0IrlMN37Zkhcg/pzKmaN7Qoh552K+UXvceqDQT5her6X5siGeMGHFbhx IRjEgaJXYZ8jDFSdgsM0pegrI4AG2ui0TTSeI5LTWxirwvJxsLLI595e8HcSTSvU KT/TF7cRZCxVqqbxsL33 =flYm -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--