From: Ralf Baechle <ralf@linux-mips.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Leon Alrae <leon.alrae@imgtec.com>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [Qemu-devel] qemu-img segfaults on MIPS hosts due to not having an executable stack
Date: Tue, 14 Jun 2016 00:10:18 +0200 [thread overview]
Message-ID: <20160613221018.GA1592@linux-mips.org> (raw)
In-Reply-To: <CAFEAcA8XEfFf45U2RQfZ4DMrwXwei=+6XzR99+D0CRUDoz=sBw@mail.gmail.com>
On Mon, Jun 13, 2016 at 04:16:02PM +0100, Peter Maydell wrote:
> On 13 June 2016 at 15:45, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Mon, Jun 13, 2016 at 03:11:08PM +0100, Peter Maydell wrote:
> >> QEMU currently allocates coroutine stacks with a plain g_malloc(),
> >> which makes them r/w but not exec. That's a bug in QEMU which we
> >> should fix (though I'm not sure how best to identify the required
> >> permissions for stacks). It's a bit unhelpful of the kernel to
> >> assume an executable stack and not give a useful diagnostic or
> >> failure mode if it's not true, though.
> >
> > I'd suggest we just #ifdef the code base on architecture, on that basis
> > all platforms except mips are probably happy with non-exec stack.
>
> Have they really all got rid of signal handler trampolines?
Apparently Android wants a non-executable stack for security reasons.
That said, some special code such as GCC's nested functions may require
stack trampolines. For such code there is the option to use the p_flags
of the PT_GNU_STACK program header to mark the stack executable. One
way to do so is to pass the option "-z execstack" to ld or a ".section
.note.GNU-stack,"",@progbits" into the assembler code which is what GCC
will do when generating trampolines.
Ralf
prev parent reply other threads:[~2016-06-13 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 14:11 [Qemu-devel] qemu-img segfaults on MIPS hosts due to not having an executable stack Peter Maydell
2016-06-13 14:45 ` Daniel P. Berrange
2016-06-13 15:16 ` Peter Maydell
2016-06-13 22:10 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613221018.GA1592@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=leon.alrae@imgtec.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).