qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] macio: Use blk_drain instead of blk_drain_all
Date: Tue, 14 Jun 2016 09:21:34 +0800	[thread overview]
Message-ID: <20160614012134.GB26269@ad.usersys.redhat.com> (raw)
In-Reply-To: <f0b47730-2be4-955d-1ee4-cb5984f04dbb@redhat.com>

On Mon, 06/13 17:33, John Snow wrote:
> 
> 
> On 06/12/2016 02:56 AM, Fam Zheng wrote:
> > We only care about the associated backend, so blk_drain is more
> > appropriate here.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  hw/ide/macio.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/ide/macio.c b/hw/ide/macio.c
> > index 78c10a0..a8c7321 100644
> > --- a/hw/ide/macio.c
> > +++ b/hw/ide/macio.c
> > @@ -400,7 +400,7 @@ static void pmac_ide_flush(DBDMA_io *io)
> >      IDEState *s = idebus_active_if(&m->bus);
> >  
> >      if (s->bus->dma->aiocb) {
> > -        blk_drain_all();
> > +        blk_drain(s->blk);
> >      }
> >  }
> >  
> > 
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 
> Shall I take this through my tree?

I think that MAINTAINERS says so. :)

Fam

  reply	other threads:[~2016-06-14  1:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  6:56 [Qemu-devel] [PATCH] macio: Use blk_drain instead of blk_drain_all Fam Zheng
2016-06-13  9:39 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2016-06-14  1:20   ` Fam Zheng
2016-06-14  9:08   ` Stefan Hajnoczi
2016-06-13 21:33 ` [Qemu-devel] " John Snow
2016-06-14  1:21   ` Fam Zheng [this message]
2016-06-14 20:26     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614012134.GB26269@ad.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).