From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCk7i-00081v-MA for qemu-devel@nongnu.org; Tue, 14 Jun 2016 04:55:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCk7g-0000Xw-TV for qemu-devel@nongnu.org; Tue, 14 Jun 2016 04:55:01 -0400 Date: Tue, 14 Jun 2016 10:54:50 +0200 From: Kevin Wolf Message-ID: <20160614085450.GE4916@noname.str.redhat.com> References: <1464694565-16784-1-git-send-email-clg@kaod.org> <574D9F0F.7060904@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hOcCNbCCxyk/YU74" Content-Disposition: inline In-Reply-To: <574D9F0F.7060904@redhat.com> Subject: Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , Peter Crosthwaite , Max Reitz , qemu-block@nongnu.org, qemu-devel@nongnu.org --hOcCNbCCxyk/YU74 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 31.05.2016 um 16:26 hat Eric Blake geschrieben: > On 05/31/2016 05:36 AM, C=E9dric Le Goater wrote: > > commit 243e6f69c129 ("m25p80: Switch to byte-based block access") > > replaced blk_read() calls with blk_pread() but return values are > > different. >=20 > Shoot, I completely missed that when I made the conversions. Now I need > to re-audit that entire series to see if the same problem happened > anywhere else. >=20 > >=20 > > Signed-off-by: C=E9dric Le Goater > > --- > > hw/block/m25p80.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Reviewed-by: Eric Blake Thanks, applied to the block branch. Kevin --hOcCNbCCxyk/YU74 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXX8ZaAAoJEH8JsnLIjy/WPloQAMOzZ51bERC2PBADLDVCKhi5 uFIQlcB/tXh4eshaX2qdOejWdZ6PgBUhVaDKz5glfJcs3Th1Ib+T0rhD6bLGIFXt alp1lv+OjcZ+cgEoh0MKrRYrccO24t7o1eUeZpI9Es2lLrIQdMcEiI+U6dBxaPMu 9AStTPIQlNIYBPXM61YdYtZkzN7J37OGglEiBdy68I+RcVYpTWDB5bGxfoHWPcdn +0af9+daQhxbdAjSFaYQH8FJYGVsdSpgwVnHo7xt97RwAQ+bxrIDqhA3lE/1rE4R Od3SsTNKVgt8ExXFcACJiPDqYWrvpgXHamkuesQlvv6ucZxKDega1BCssMZH2C/K nTF1yCh3UlqrKNF1Vm5anTt022x32GqkvT1Dd2eiD5kdKf2FK323xqGrmQm8ZJsh EAvorJi11BeSJkvaade7XjK8hFqKKV3qbvr3Nl3iKA2tpnnNhbg2kWcbA8s8jPU1 5JKde/YIsqDdAvOVXRKazRKfyjxVMRtSvfkWIyKrhmLFMyUiHrAfLiDB3rMdS8E1 icAk1zqdY4oBIojw4EVrtYWZFMcIZMBrlXnBMe4jujgO2qcB09sHlw52XoZHLSGu 0JaI7BJZBanJtwuWxFlYDc194NuvNPI7Lceyp7rw5K6GXKf4z/XXsBmboVD+X9XY K3/31wLhDegIv9JqR6YR =A0Ny -----END PGP SIGNATURE----- --hOcCNbCCxyk/YU74--