From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCo1O-00044H-8p for qemu-devel@nongnu.org; Tue, 14 Jun 2016 09:04:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCo1M-0006V0-9x for qemu-devel@nongnu.org; Tue, 14 Jun 2016 09:04:45 -0400 Date: Tue, 14 Jun 2016 15:04:35 +0200 From: Kevin Wolf Message-ID: <20160614130435.GA14803@noname.str.redhat.com> References: <1465395011-26088-1-git-send-email-kwolf@redhat.com> <1465395011-26088-7-git-send-email-kwolf@redhat.com> <20160614120922.GB17919@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <20160614120922.GB17919@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH 6/6] block: Don't enforce 512 byte minimum alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-block@nongnu.org, eblake@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, famz@redhat.com, qemu-devel@nongnu.org --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 14.06.2016 um 14:09 hat Stefan Hajnoczi geschrieben: > On Wed, Jun 08, 2016 at 04:10:11PM +0200, Kevin Wolf wrote: > > diff --git a/block.c b/block.c > > index f54bc25..3d850a2 100644 > > --- a/block.c > > +++ b/block.c > > @@ -937,7 +937,7 @@ static int bdrv_open_common(BlockDriverState *bs, B= drvChild *file, > > goto fail_opts; > > } > > =20 > > - bs->request_alignment =3D 512; > > + bs->request_alignment =3D drv->bdrv_co_preadv ? 1 : 512; >=20 > What happens in the raw-posix.c AIO case? There we should still use > 512. I'm only changing the default value here. raw-posix already overrides bs->request_alignment as needed, see raw_probe_alignment(). Kevin --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIbBAEBAgAGBQJXYADjAAoJEH8JsnLIjy/WTfAP9RH1W6RyK8tS3M8jftcsQCHU I7HZbnRqCw/yz8YmwBavpX8aw+PiJzGIJk89UG4yXwxDHWJKVMXgeW1BZ1JEn1F0 GiccIjuV5fEdpSQ4TAjk/21RYuuH7w8cqN9ylFJz3TGc4LdHzGubcqZglaCVOp+3 4aU9S7wrAkBgKEz5adj8fFC5eVmrVw9zsb5bzDoMbvr/PHkkNzT8uX+jNg7eQwdP euGmXsxjc0We+IDgZm2fdpT3A132BXEJasXgsp9e3lxY9SZamiS7MLx8GS5Iso97 /Km6PkNfYaYdU0RIop3RZQkwp7+zaoNl8fHSvnZ5oxPfUxYJrg/h/5so4pPhl8am EKAedvNfnqexC/wB9SIrFtzVsuMDg9+pUEuyathv4yJ1Ld8FmJ0+UDVPpoix0HbR N6KdaVt+HgUlD5sHlmcgJay2uUExKYWk99QUomYIk4hYChfHrNMMPAWMt12IsF1z X0XMuuIggWSIOgcdNiF6IUu2AJupgM2P7Hx/If2DaBO/8jFsiO4pBhmOB+RtVvJC 2hobBCJwVpRIKrESM900rs9t+tVFuZYH35/uVRdF6yKOJ+wy7tNtn9db51LiTK04 z/X5GwZEVugopAIWQUkKUgvi31DsPFWS6AxT6STdcfT8mBG15ovvmvrXOB6v2TCp PjTyf//nBmfd4/rgi7o= =qsGH -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--