Re: [Qemu-devel] [PATCH 5/7] virtio-ccw: Provide traces for indicator changes

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Wed,  8 Jun 2016 13:02:43 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> From: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> This allows to trace changes in the summary and queue indicators
> for the non-irqfd case. For irqfd, kernel traces are needed instead.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  hw/s390x/virtio-ccw.c | 1 +
>  trace-events          | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index 7b265e4..262027b 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -1091,6 +1091,7 @@ static uint8_t virtio_set_ind_atomic(SubchDev *sch, uint64_t ind_loc,
>          ind_old = *ind_addr;
>          ind_new = ind_old | to_be_set;
>      } while (atomic_cmpxchg(ind_addr, ind_old, ind_new) != ind_old);
> +    trace_virtio_ccw_set_ind(ind_loc, ind_old, ind_new);
>      cpu_physical_memory_unmap(ind_addr, len, 1, len);
> 
>      return ind_old;
> diff --git a/trace-events b/trace-events
> index c50b870..f672d9c 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1472,6 +1472,7 @@ css_adapter_interrupt(uint8_t isc) "CSS: adapter I/O interrupt (isc %x)"
>  # hw/s390x/virtio-ccw.c
>  virtio_ccw_interpret_ccw(int cssid, int ssid, int schid, int cmd_code) "VIRTIO-CCW: %x.%x.%04x: interpret command %x"
>  virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *devno_mode) "VIRTIO-CCW: add subchannel %x.%x.%04x, devno %04x (%s)"
> +virtio_ccw_set_ind(uint64_t ind_loc, uint8_t ind_old, uint8_t ind_new) "VIRTIO-CCW: indicator at %lx: %x->%x"

Needs to be PRIu64 instead of lx. I'll fix it.

> 
>  # hw/intc/s390_flic_kvm.c
>  flic_create_device(int err) "flic: create device failed %d"