From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCmy5-0001wa-CM for qemu-devel@nongnu.org; Tue, 14 Jun 2016 07:57:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCmy1-0006hA-7c for qemu-devel@nongnu.org; Tue, 14 Jun 2016 07:57:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCmy0-0006gt-VH for qemu-devel@nongnu.org; Tue, 14 Jun 2016 07:57:13 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5EBoqwv137040 for ; Tue, 14 Jun 2016 07:57:11 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0a-001b2d01.pphosted.com with ESMTP id 23jgpd1u1h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 14 Jun 2016 07:57:11 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Jun 2016 12:57:08 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8A56417D805A for ; Tue, 14 Jun 2016 12:58:16 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5EBv3ug917874 for ; Tue, 14 Jun 2016 11:57:03 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u5EBv23u022362 for ; Tue, 14 Jun 2016 05:57:03 -0600 Date: Tue, 14 Jun 2016 13:56:59 +0200 From: Cornelia Huck In-Reply-To: <1465383765-18754-6-git-send-email-cornelia.huck@de.ibm.com> References: <1465383765-18754-1-git-send-email-cornelia.huck@de.ibm.com> <1465383765-18754-6-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160614135659.6e4ae23d.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 5/7] virtio-ccw: Provide traces for indicator changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com On Wed, 8 Jun 2016 13:02:43 +0200 Cornelia Huck wrote: > From: Christian Borntraeger > > This allows to trace changes in the summary and queue indicators > for the non-irqfd case. For irqfd, kernel traces are needed instead. > > Signed-off-by: Christian Borntraeger > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw.c | 1 + > trace-events | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 7b265e4..262027b 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -1091,6 +1091,7 @@ static uint8_t virtio_set_ind_atomic(SubchDev *sch, uint64_t ind_loc, > ind_old = *ind_addr; > ind_new = ind_old | to_be_set; > } while (atomic_cmpxchg(ind_addr, ind_old, ind_new) != ind_old); > + trace_virtio_ccw_set_ind(ind_loc, ind_old, ind_new); > cpu_physical_memory_unmap(ind_addr, len, 1, len); > > return ind_old; > diff --git a/trace-events b/trace-events > index c50b870..f672d9c 100644 > --- a/trace-events > +++ b/trace-events > @@ -1472,6 +1472,7 @@ css_adapter_interrupt(uint8_t isc) "CSS: adapter I/O interrupt (isc %x)" > # hw/s390x/virtio-ccw.c > virtio_ccw_interpret_ccw(int cssid, int ssid, int schid, int cmd_code) "VIRTIO-CCW: %x.%x.%04x: interpret command %x" > virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *devno_mode) "VIRTIO-CCW: add subchannel %x.%x.%04x, devno %04x (%s)" > +virtio_ccw_set_ind(uint64_t ind_loc, uint8_t ind_old, uint8_t ind_new) "VIRTIO-CCW: indicator at %lx: %x->%x" Needs to be PRIu64 instead of lx. I'll fix it. > > # hw/intc/s390_flic_kvm.c > flic_create_device(int err) "flic: create device failed %d"