From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38284)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bCyl3-0007yr-2O
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 20:32:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bCykz-0002Mx-SK
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 20:32:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56161)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bCykz-0002Mr-Mr
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 20:32:33 -0400
Date: Wed, 15 Jun 2016 08:32:26 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160615003226.GA28081@ad.usersys.redhat.com>
References: <20160614180734.8782-1-sbruno@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160614180734.8782-1-sbruno@freebsd.org>
Subject: Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to
 resolve non-fatal build error on FreeBSD.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sean Bruno <sbruno@freebsd.org>
Cc: qemu-devel@nongnu.org

On Tue, 06/14 11:07, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems.  Use -s
> instead to match the rest of the Makefile uses.  This fixes a non-fatal
> error seen on FreeBSD.
> 
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>  				printf '""\n'; \
>  			fi; \
>  		fi) > $@.tmp)
> -	$(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +	$(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>  
>  config-host.h: config-host.h-timestamp
>  config-host.h-timestamp: config-host.mak
> -- 
> 2.8.4
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>