* [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
@ 2016-06-14 18:07 Sean Bruno
2016-06-14 22:11 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sean Bruno @ 2016-06-14 18:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Sean Bruno
The --quiet argument is not available on all operating systems. Use -s
instead to match the rest of the Makefile uses. This fixes a non-fatal
error seen on FreeBSD.
Signed-off-by: Sean Bruno <sbruno@freebsd.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ed4032a..a7a356a 100644
--- a/Makefile
+++ b/Makefile
@@ -185,7 +185,7 @@ qemu-version.h: FORCE
printf '""\n'; \
fi; \
fi) > $@.tmp)
- $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
+ $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
config-host.h: config-host.h-timestamp
config-host.h-timestamp: config-host.mak
--
2.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
2016-06-14 18:07 [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
@ 2016-06-14 22:11 ` Eric Blake
2016-06-15 0:32 ` Fam Zheng
2016-07-05 16:59 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2016-06-14 22:11 UTC (permalink / raw)
To: Sean Bruno, qemu-devel, Paolo Bonzini, Fam Zheng
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On 06/14/2016 12:07 PM, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
See also my pending patch related to this code:
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg02375.html
if Paolo wants to pull in all the changes related to version generation
in his next pull request.
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
> config-host.h: config-host.h-timestamp
> config-host.h-timestamp: config-host.mak
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
2016-06-14 18:07 [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
2016-06-14 22:11 ` Eric Blake
@ 2016-06-15 0:32 ` Fam Zheng
2016-07-05 16:59 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2016-06-15 0:32 UTC (permalink / raw)
To: Sean Bruno; +Cc: qemu-devel
On Tue, 06/14 11:07, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
> config-host.h: config-host.h-timestamp
> config-host.h-timestamp: config-host.mak
> --
> 2.8.4
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
2016-06-14 18:07 [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
2016-06-14 22:11 ` Eric Blake
2016-06-15 0:32 ` Fam Zheng
@ 2016-07-05 16:59 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2016-07-05 16:59 UTC (permalink / raw)
To: Sean Bruno, qemu-devel
On 14/06/2016 20:07, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
> config-host.h: config-host.h-timestamp
> config-host.h-timestamp: config-host.mak
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-05 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14 18:07 [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
2016-06-14 22:11 ` Eric Blake
2016-06-15 0:32 ` Fam Zheng
2016-07-05 16:59 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).