From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD16c-00053f-BC for qemu-devel@nongnu.org; Tue, 14 Jun 2016 23:03:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD16X-0003I4-AS for qemu-devel@nongnu.org; Tue, 14 Jun 2016 23:03:01 -0400 Date: Wed, 15 Jun 2016 11:01:57 +1000 From: David Gibson Message-ID: <20160615010157.GX4882@voom.fritz.box> References: <1465795496-15071-1-git-send-email-clg@kaod.org> <1465795496-15071-3-git-send-email-clg@kaod.org> <20160614061527.GO4882@voom.fritz.box> <575FA99C.9000507@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8D1TCnBmjJJF2KCx" Content-Disposition: inline In-Reply-To: <575FA99C.9000507@kaod.org> Subject: Re: [Qemu-devel] [PATCH 02/10] ppc: Create cpu_ppc_set_papr() helper (for LPCR) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Benjamin Herrenschmidt --8D1TCnBmjJJF2KCx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2016 at 08:52:12AM +0200, C=E9dric Le Goater wrote: > On 06/14/2016 08:15 AM, David Gibson wrote: > > On Mon, Jun 13, 2016 at 07:24:48AM +0200, C=E9dric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> And move the code adjusting the MSR mask and calling kvmppc_set_papr() > >> to it. This allows us to add a few more things such as disabling setti= ng > >> of MSR:HV and appropriate LPCR bits which will be used when fixing > >> the exception model. > >> > >> Signed-off-by: Benjamin Herrenschmidt > >> Reviewed-by: David Gibson > >> [clg: previous commit 26a7f1291bb5 did not include the LPCR setting as > >> it was not needed at the time ] > >=20 > > I see how this came about, but it means the commit message (both long > > and short) is confusingly mismatched from the code now. >=20 > OK. I will work on it. >=20 > For my education, how much can we change the initial changelog of a patch= ? > Is it considered as part of the code ?=20 I'm not entirely sure I follow the question, but AFAIK it's entirely ok to reword and clarify a commit message as it moves through the signed-off-by chain. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8D1TCnBmjJJF2KCx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXYKkFAAoJEGw4ysog2bOS/I0QAOBmtfIoAREw5VTm8zTriBpq 5p1mTn0P2eC+HeKnJ2+3dr/ojLRr/sbsl+NtwsL1uVLQc2f5X7EwDe/lL4LUAP6N ZUVqIhZkko3HYBePx5MwK2JMV7P6fa36ZtZKZ4SXlC+OLdosBlD1Dcrj+n7E8FYW xV1p7JM6Ty8zm0hlzer2rj0cXZ0QdYrDluez8NpF1OjvabsFdEUswElnuUcUQAIC DjiixbQdRmxm/X2vq3+lVviHpt9F92N8Ct74BHEPqkhN5pbVku3OpT+sKIRg5m3Q MIUEJK7fW3it/+aPP22hG9F02NyrzdslfwFsFIxdBvOKjUUvEvgIdLtag6mZFd0D /PQR97LpXI22Ftnupc1AwnHX0KPMUc5S3+D6bJiXljiG4ByUjCFM5nBEVI6KC/aC 3wMntxnDx809/0nxuGD8I9v0aDRPVZ+T75pgFs8SCRxBUWfHqZocvdJO5WOLulXN 61oKABOCt/5rqPtabdlgJoMz4iTvoThblSCOWqfqP2VQA12x6PSJSRvGQp5M47LD srCrBvVD+Co9O6a/uZtnTM5sNcBdfzBNd4rATKXk16VMEbs7gCHdJ/XHvVlUG3RC Y7Y5MDFc+6u2sQDJ8mTwQTn8+tYGxp7puCegrF2MztecN5xjwC3jisAzBFKpydS0 Bhi+p0HJSrhz9GRSA+v7 =2c4C -----END PGP SIGNATURE----- --8D1TCnBmjJJF2KCx--