From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD01t-0002WK-NG for qemu-devel@nongnu.org; Tue, 14 Jun 2016 21:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD01r-0003Bp-T5 for qemu-devel@nongnu.org; Tue, 14 Jun 2016 21:54:04 -0400 Date: Wed, 15 Jun 2016 09:53:48 +0800 From: Fam Zheng Message-ID: <20160615015348.GA14453@ad.usersys.redhat.com> References: <1463550807-2750-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Jeff Cody , Kevin Wolf , qemu-block@nongnu.org, jsnow@redhat.com, qemu-stable@nongnu.org On Tue, 06/14 16:49, Max Reitz wrote: > On 18.05.2016 07:53, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > > > Cc: qemu-stable@nongnu.org > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 34 ++++++++++++++++++---------------- > > 1 file changed, 18 insertions(+), 16 deletions(-) > > Sorry for having waited so long (I was thinking that maybe Jeff wanted > to take this patch), but now the patch no longer applies and I don't > feel comfortable with just fixing it up myself; git-backport-diff tells > me the required changes are "[0015] [FC]". No problem! I'll rebase it and submit again. Fam