From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD4rM-0001Tx-U8 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 03:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD4rK-0004Vl-VO for qemu-devel@nongnu.org; Wed, 15 Jun 2016 03:03:31 -0400 Date: Wed, 15 Jun 2016 09:02:57 +0200 From: Wouter Verhelst Message-ID: <20160615070257.GB3787@grep.be> References: <1463006384-7734-1-git-send-email-eblake@redhat.com> <1463006384-7734-5-git-send-email-eblake@redhat.com> <852e526a-5235-499a-741e-a695f5e74f83@redhat.com> <575EA656.80508@redhat.com> <6DD06745-C91C-4BFB-BFE5-92E5982ACB42@alex.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6DD06745-C91C-4BFB-BFE5-92E5982ACB42@alex.org.uk> Subject: Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Eric Blake , "nbd-general@lists.sourceforge.net" , Paolo Bonzini , qemu-block@nongnu.org, "qemu-devel@nongnu.org" On Mon, Jun 13, 2016 at 10:41:05PM +0100, Alex Bligh wrote: > For amusement value, the non-threaded handler (which is not used > any more) does not send any payload on an error: > https://github.com/yoe/nbd/blob/master/nbd-server.c#L1734 nbd-server used to just drop the connection on read error. > In essence read error handling is a horrible mess in NBD, and > I would not expect it to work in general :-( -- < ron> I mean, the main *practical* problem with C++, is there's like a dozen people in the world who think they really understand all of its rules, and pretty much all of them are just lying to themselves too. -- #debian-devel, OFTC, 2016-02-12