From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD5nz-0006bL-9h for qemu-devel@nongnu.org; Wed, 15 Jun 2016 04:04:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD5nx-0002wU-BA for qemu-devel@nongnu.org; Wed, 15 Jun 2016 04:04:06 -0400 Date: Wed, 15 Jun 2016 10:03:54 +0200 From: Kevin Wolf Message-ID: <20160615080354.GD4566@noname.redhat.com> References: <1465817409-26542-1-git-send-email-berrange@redhat.com> <20160613153641.GF5968@noname.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160613153641.GF5968@noname.str.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2] block: drop support for using qcow[2] encryption with system emulators List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster Am 13.06.2016 um 17:36 hat Kevin Wolf geschrieben: > Am 13.06.2016 um 13:30 hat Daniel P. Berrange geschrieben: > > So rather than fix the crash, and backport it to stable > > releases, just go ahead with what we have warned users about > > and disable any use of qcow2 encryption in the system > > emulators. qemu-img/qemu-io/qemu-nbd are still able to access > > qcow2 encrypted images for the sake of data conversion. > > > > In the future, qcow2 will gain support for the alternative > > luks format, but when this happens it'll be using the > > '-object secret' infrastructure for gettings keys, which > > avoids this problematic scenario entirely. > > > > Signed-off-by: Daniel P. Berrange > > Apart from the commit message comments above and from Eric, this looks > good to me. I'll give a little more time for review before merging this. Thanks, applied to the block branch. Kevin