From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] qcow2: Avoid making the L1 table too big
Date: Wed, 15 Jun 2016 17:36:30 +0200 [thread overview]
Message-ID: <20160615153630.2116-3-mreitz@redhat.com> (raw)
In-Reply-To: <20160615153630.2116-1-mreitz@redhat.com>
We refuse to open images whose L1 table we deem "too big". Consequently,
we should not produce such images ourselves.
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-cluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 893ddf6..335b9b0 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -65,7 +65,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t min_size,
}
}
- if (new_l1_size > INT_MAX / sizeof(uint64_t)) {
+ if (new_l1_size > QCOW_MAX_L1_SIZE / sizeof(uint64_t)) {
return -EFBIG;
}
--
2.8.3
next prev parent reply other threads:[~2016-06-15 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 15:36 [Qemu-devel] [PATCH 0/2] qcow2: Avoid making the L1 table too big Max Reitz
2016-06-15 15:36 ` [Qemu-devel] [PATCH 1/2] qemu-img: Use strerror() for generic resize error Max Reitz
2016-06-15 15:44 ` Eric Blake
2016-06-15 15:36 ` Max Reitz [this message]
2016-06-15 15:43 ` [Qemu-devel] [PATCH 2/2] qcow2: Avoid making the L1 table too big Eric Blake
2016-07-06 8:40 ` Kevin Wolf
2016-07-06 12:47 ` Max Reitz
2016-07-06 12:54 ` Kevin Wolf
2016-07-05 17:37 ` [Qemu-devel] [PATCH 0/2] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615153630.2116-3-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).