From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCs7-0005kF-Fy for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDCs5-00007t-7g for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:36:50 -0400 From: Max Reitz Date: Wed, 15 Jun 2016 17:36:30 +0200 Message-Id: <20160615153630.2116-3-mreitz@redhat.com> In-Reply-To: <20160615153630.2116-1-mreitz@redhat.com> References: <20160615153630.2116-1-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] qcow2: Avoid making the L1 table too big List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Max Reitz , Kevin Wolf , qemu-stable@nongnu.org We refuse to open images whose L1 table we deem "too big". Consequently, we should not produce such images ourselves. Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 893ddf6..335b9b0 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -65,7 +65,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t min_size, } } - if (new_l1_size > INT_MAX / sizeof(uint64_t)) { + if (new_l1_size > QCOW_MAX_L1_SIZE / sizeof(uint64_t)) { return -EFBIG; } -- 2.8.3