From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDLfU-0004Wc-57 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 21:00:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDLfR-0002hn-Qx for qemu-devel@nongnu.org; Wed, 15 Jun 2016 21:00:23 -0400 Date: Thu, 16 Jun 2016 11:00:02 +1000 From: David Gibson Message-ID: <20160616010002.GG28087@voom.fritz.box> References: <1465964907-17637-1-git-send-email-gwshan@linux.vnet.ibm.com> <20160615044623.GB21472@voom.fritz.box> <20160615050315.GC21472@voom.fritz.box> <20160615105255.0b2ddca4@t450s.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BzCohdixPhurzSK4" Content-Disposition: inline In-Reply-To: <20160615105255.0b2ddca4@t450s.home> Subject: Re: [Qemu-devel] [PATCH] vfio: Fix broken EEH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: Gavin Shan , qemu-ppc@nongnu.org, agraf@suse.de, aik@ozlabs.ru, qemu-devel --BzCohdixPhurzSK4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 15, 2016 at 10:52:55AM -0600, Alex Williamson wrote: > On Wed, 15 Jun 2016 15:03:15 +1000 > David Gibson wrote: >=20 > > On Wed, Jun 15, 2016 at 02:46:23PM +1000, David Gibson wrote: > > > On Wed, Jun 15, 2016 at 02:28:27PM +1000, Gavin Shan wrote: =20 > > > > vfio_eeh_container_op() is the backend that communicates with > > > > host kernel to support EEH functionality in QEMU. However, the > > > > functon should return the value from host kernel instead of 0 > > > > unconditionally. > > > >=20 > > > > Signed-off-by: Gavin Shan =20 > > >=20 > > > Applied to ppc-for-2.7, thanks. =20 > >=20 > > Hang on, wait.. forgot I should get an ack for this from you, Alex. > > I'll keep it in my tree for now, unless you tell me you'd prefer to > > take it through yours. >=20 > Hmm, clearly this patch should have cc'd qemu-devel from the start. Yeah. Gavin's not usually a qemu developer and I forgot a bunch of things in my 15s version of how-to-submit-qemu-patches. > Go > ahead and take it through your tree David. Will do, thanks. >=20 > Acked-by: Alex Williamson >=20 > >=20 > > >=20 > > > We should probably look at applying this to the 2.6 stable branch as = well. > > > =20 > > > > --- > > > > hw/vfio/common.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > > > > index e51ed3a..e51db46 100644 > > > > --- a/hw/vfio/common.c > > > > +++ b/hw/vfio/common.c > > > > @@ -1258,7 +1258,7 @@ static int vfio_eeh_container_op(VFIOContaine= r *container, uint32_t op) > > > > return -errno; > > > > } > > > > =20 > > > > - return 0; > > > > + return ret; > > > > } > > > > =20 > > > > static VFIOContainer *vfio_eeh_as_container(AddressSpace *as) =20 > > > =20 > >=20 > >=20 > >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --BzCohdixPhurzSK4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXYfoSAAoJEGw4ysog2bOSdp4QANhcaGsz9tvW/1Z/LrBnpQjp MrytB6x1jeLDw0K+ddW2r4j3weQoZNy57lTjX86UidCcxIe8u34QeR6y9fk18Icj LpN/VUzRWrt0CGqrGpkeRYzPvimhocttd5sF5F+gur/WANmpOo0ogWdAghZjb/5X RlBJrNKqvIauSjkNrnsyohA3eyxvb1qjIGvh/zCQcqBN6dAbSACxF757ElNLGnV9 j6l9iqmvyi/VT73z2TYBpSUei5VdDWjvlgSgPPZwtIzbCni6Ocm1eyxdMlvWZ8C4 8guPsf5jAdrWpVHd65I1DyH1fUBxhk2ERH1kFhm2I5O/4UQjSP2CIrEMLQp5D5zB OcYkyrSc+vKR52Npa5Q+pTuphhGiPwqLSAPr/7pz1ywZ6DzRohEN3udbb4JdRdbk 7OedFB/e5mVjWBMUPyeYolVJAqsqBLyPTonAtt6w0m76q6pcWLj5Wqgplx05mND4 B2jvlA8JlF4nN9JwHPnfV5zPnMBYAN+Iw99Mp5VDdY9T/jr4jKlVh2DDjNpuWoNq USpObiTlPJtIL85rpNKEsftVIm6B+HGn/e8rz7pbB/WR2WUp2LD2DI9rITPpcyFm qau984cDOiYpBFsgUdS77djRMCckHEIt3iPEvdOcS1m9F5XWhtMhzhcrUCQthjnO wb7gzM0+/tW0Af52ghRw =wVGO -----END PGP SIGNATURE----- --BzCohdixPhurzSK4--