Re: [Qemu-devel] [PATCH] vfio: Fix broken EEH

Re: [Qemu-devel] [PATCH] vfio: Fix broken EEH

[Alex Williamson]

On Wed, 15 Jun 2016 15:03:15 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Wed, Jun 15, 2016 at 02:46:23PM +1000, David Gibson wrote:
> > On Wed, Jun 15, 2016 at 02:28:27PM +1000, Gavin Shan wrote:  
> > > vfio_eeh_container_op() is the backend that communicates with
> > > host kernel to support EEH functionality in QEMU. However, the
> > > functon should return the value from host kernel instead of 0
> > > unconditionally.
> > > 
> > > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>  
> > 
> > Applied to ppc-for-2.7, thanks.  
> 
> Hang on, wait.. forgot I should get an ack for this from you, Alex.
> I'll keep it in my tree for now, unless you tell me you'd prefer to
> take it through yours.

Hmm, clearly this patch should have cc'd qemu-devel from the start.  Go
ahead and take it through your tree David.

Acked-by: Alex Williamson <alex.williamson@redhat.com>

> 
> > 
> > We should probably look at applying this to the 2.6 stable branch as well.
> >   
> > > ---
> > >  hw/vfio/common.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> > > index e51ed3a..e51db46 100644
> > > --- a/hw/vfio/common.c
> > > +++ b/hw/vfio/common.c
> > > @@ -1258,7 +1258,7 @@ static int vfio_eeh_container_op(VFIOContainer *container, uint32_t op)
> > >          return -errno;
> > >      }
> > >  
> > > -    return 0;
> > > +    return ret;
> > >  }
> > >  
> > >  static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)  
> >   
> 
> 
> 

Re: [Qemu-devel] [PATCH] vfio: Fix broken EEH

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]

On Wed, Jun 15, 2016 at 10:52:55AM -0600, Alex Williamson wrote:
> On Wed, 15 Jun 2016 15:03:15 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Wed, Jun 15, 2016 at 02:46:23PM +1000, David Gibson wrote:
> > > On Wed, Jun 15, 2016 at 02:28:27PM +1000, Gavin Shan wrote:  
> > > > vfio_eeh_container_op() is the backend that communicates with
> > > > host kernel to support EEH functionality in QEMU. However, the
> > > > functon should return the value from host kernel instead of 0
> > > > unconditionally.
> > > > 
> > > > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>  
> > > 
> > > Applied to ppc-for-2.7, thanks.  
> > 
> > Hang on, wait.. forgot I should get an ack for this from you, Alex.
> > I'll keep it in my tree for now, unless you tell me you'd prefer to
> > take it through yours.
> 
> Hmm, clearly this patch should have cc'd qemu-devel from the start.

Yeah. Gavin's not usually a qemu developer and I forgot a bunch of
things in my 15s version of how-to-submit-qemu-patches.

> Go
> ahead and take it through your tree David.

Will do, thanks.

> 
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
> 
> > 
> > > 
> > > We should probably look at applying this to the 2.6 stable branch as well.
> > >   
> > > > ---
> > > >  hw/vfio/common.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> > > > index e51ed3a..e51db46 100644
> > > > --- a/hw/vfio/common.c
> > > > +++ b/hw/vfio/common.c
> > > > @@ -1258,7 +1258,7 @@ static int vfio_eeh_container_op(VFIOContainer *container, uint32_t op)
> > > >          return -errno;
> > > >      }
> > > >  
> > > > -    return 0;
> > > > +    return ret;
> > > >  }
> > > >  
> > > >  static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)  
> > >   
> > 
> > 
> > 
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]