From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDPY4-0002i6-TM for qemu-devel@nongnu.org; Thu, 16 Jun 2016 01:09:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDPY2-00066O-UU for qemu-devel@nongnu.org; Thu, 16 Jun 2016 01:08:59 -0400 Date: Thu, 16 Jun 2016 13:08:46 +0800 From: Fam Zheng Message-ID: <20160616050846.GD12178@ad.usersys.redhat.com> References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-3-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465939839-30097-3-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 02/17] block: Document supported flags during bdrv_aligned_preadv() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, Stefan Hajnoczi , Max Reitz On Tue, 06/14 15:30, Eric Blake wrote: > We don't pass any flags on to drivers to handle. Tighten an > assert to explain why we pass 0 to bdrv_driver_preadv(), and add > some comments on things to be aware of if we want to turn on > per-BDS BDRV_REQ_FUA support during reads in the future. Also, > document that we may want to consider using unmap during > copy-on-read operations where the read is all zeroes. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng